From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1uL1oD-0006lE-BN for mharc-qemu-trivial@gnu.org; Fri, 30 May 2025 11:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uL1oC-0006kp-AP for qemu-trivial@nongnu.org; Fri, 30 May 2025 11:38:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uL1oA-0008Bg-KX for qemu-trivial@nongnu.org; Fri, 30 May 2025 11:38:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748619489; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G3msaTiIXkgzlqvH4DuyIlG+91cFxj2PufezYbsAIXg=; b=UtAcrVQ6JXEqTIQARyoCI6cytfsq7zZrpMaFxNOp+muQmKX//6xpiziZugZseto01JCsh+ jPHJYPpYN8ke5CouRgu3Aw9DG05nsQ4LbxWKZfQhREoDrfxy5DPEpiLdDiP8Eg7AzhTx0N h1/wKnYw5WQT5VQoFkiY7glImUIQglA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-z_so5igdM2a10LVXJ9QZug-1; Fri, 30 May 2025 11:38:06 -0400 X-MC-Unique: z_so5igdM2a10LVXJ9QZug-1 X-Mimecast-MFC-AGG-ID: z_so5igdM2a10LVXJ9QZug_1748619485 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21881195608C; Fri, 30 May 2025 15:38:05 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.173]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A57E6180087C; Fri, 30 May 2025 15:38:02 +0000 (UTC) Date: Fri, 30 May 2025 16:37:59 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Matheus Tavares Bernardino Cc: qemu-devel@nongnu.org, jmarcin@redhat.com, qemu-trivial@nongnu.org, pbonzini@redhat.com, vsementsov@yandex-team.ru, brian.cain@oss.qualcomm.com Subject: Re: [PATCH] tests/unit/test-util-sockets: fix mem-leak on error object Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <518d94c7db20060b2a086cf55ee9bffab992a907.1748280011.git.matheus.bernardino@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <518d94c7db20060b2a086cf55ee9bffab992a907.1748280011.git.matheus.bernardino@oss.qualcomm.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.907, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2025 15:38:12 -0000 On Mon, May 26, 2025 at 10:20:55AM -0700, Matheus Tavares Bernardino wrote: > The test fails with --enable-asan as the error struct is never freed. > In the case where the test expects a success but it fails, let's also > report the error for debugging (it will be freed internally). > > Fixes 316e8ee8d6 ("util/qemu-sockets: Refactor inet_parse() to use QemuOpts") > Signed-off-by: Matheus Tavares Bernardino > --- > tests/unit/test-util-sockets.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|