All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH v2] x86/mm: resize user_pcid_flush_mask for PTI / broadcast TLB flush combination
Date: Sat, 31 May 2025 09:25:24 +0200	[thread overview]
Message-ID: <aDqu5Fhbf3mV6Xsj@gmail.com> (raw)
In-Reply-To: <20250530174136.61b8086a@fangorn>


* Rik van Riel <riel@surriel.com> wrote:

> [re-sent]
> ---8<---
> From 96958fa1ed02e2434305fc7b0e37374eee899daf Mon Sep 17 00:00:00 2001
> From: Rik van Riel <riel@meta.com>
> Date: Fri, 16 May 2025 08:37:04 -0700
> Subject: [PATCH] x86/mm: resize user_pcid_flush_mask for PTI / broadcast TLB flush combination

1)

Please always check whether the title style you are using matches that 
of the subsystem you are submitting it to. (x86 in this case, and no, 
it doesn't match it)

2)

Also, 'resize' is not the proper verb for a bug fix ...

> - invalidate_user_asid() sets a bit corresponding to the process pcid in user_pcid_flush_mask
> - SWITCH_TO_USER_CR3 tests and clears a bit corresponding to the process PCID in user_pcid_flush_mask

3)

Why are 'pcid' and 'PCID' capitalized differently right next to each 
other? This is completely unnecessary noise that makes a maintainer 
question of how attentively this patch was created.

Thanks,

	Ingo

  reply	other threads:[~2025-05-31  7:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-30 21:41 [PATCH v2] x86/mm: resize user_pcid_flush_mask for PTI / broadcast TLB flush combination Rik van Riel
2025-05-31  7:25 ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-05-16 16:33 [PATCH] " Rik van Riel
2025-05-17  7:59 ` Ingo Molnar
2025-05-18  0:12   ` [PATCH v2] " Rik van Riel
2025-05-18  6:25     ` Ingo Molnar
2025-05-18 16:22       ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDqu5Fhbf3mV6Xsj@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.