From: Mike Rapoport <rppt@kernel.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Dev Jain <dev.jain@arm.com>,
akpm@linux-foundation.org, david@redhat.com,
catalin.marinas@arm.com, will@kernel.org,
Liam.Howlett@oracle.com, vbabka@suse.cz, surenb@google.com,
mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
steven.price@arm.com, gshan@redhat.com,
linux-arm-kernel@lists.infradead.org,
yang@os.amperecomputing.com, ryan.roberts@arm.com,
anshuman.khandual@arm.com
Subject: Re: [PATCH v3 1/2] arm64: pageattr: Use pagewalk API to change memory permissions
Date: Sun, 15 Jun 2025 10:25:37 +0300 [thread overview]
Message-ID: <aE51cWMkSfNJ5i4c@kernel.org> (raw)
In-Reply-To: <8077b321-8953-46aa-b06d-95c91823e6ce@lucifer.local>
On Fri, Jun 13, 2025 at 05:27:27PM +0100, Lorenzo Stoakes wrote:
> On Fri, Jun 13, 2025 at 07:13:51PM +0530, Dev Jain wrote:
> > -/*
> > - * This function assumes that the range is mapped with PAGE_SIZE pages.
> > - */
> > -static int __change_memory_common(unsigned long start, unsigned long size,
> > +static int ___change_memory_common(unsigned long start, unsigned long size,
> > pgprot_t set_mask, pgprot_t clear_mask)
>
> I wouldn't presume to comment on conventions in arm64 arch code, but that's
> a lot of underscores :P
>
> I wonder if this is the best name for it as you're not only invoking it
> from __change_memory_common()?
Could update_range_pgport() work?
> And yes this is a pedantic comment, I realise :)
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-06-15 7:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 13:43 [PATCH v3 0/2] Enable permission change on arm64 kernel block mappings Dev Jain
2025-06-13 13:43 ` [PATCH v3 1/2] arm64: pageattr: Use pagewalk API to change memory permissions Dev Jain
2025-06-13 16:27 ` Lorenzo Stoakes
2025-06-14 14:50 ` Karim Manaouil
2025-06-19 4:03 ` Dev Jain
2025-06-25 10:57 ` Ryan Roberts
2025-06-15 7:25 ` Mike Rapoport [this message]
2025-06-25 10:57 ` Ryan Roberts
2025-06-15 7:32 ` Mike Rapoport
2025-06-19 4:10 ` Dev Jain
2025-06-25 11:04 ` Ryan Roberts
2025-06-25 20:40 ` Yang Shi
2025-06-26 8:47 ` Ryan Roberts
2025-06-26 21:08 ` Yang Shi
2025-06-25 11:20 ` Ryan Roberts
2025-06-26 5:47 ` Dev Jain
2025-06-26 8:15 ` Ryan Roberts
2025-06-13 13:43 ` [PATCH v3 2/2] arm64: pageattr: Enable huge-vmalloc permission change Dev Jain
2025-06-25 11:08 ` Ryan Roberts
2025-06-25 11:16 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aE51cWMkSfNJ5i4c@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=ryan.roberts@arm.com \
--cc=steven.price@arm.com \
--cc=surenb@google.com \
--cc=suzuki.poulose@arm.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.