All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Casey Connolly <casey.connolly@linaro.org>
Cc: Tom Rini <trini@konsulko.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Sumit Garg <sumit.garg@kernel.org>,
	u-boot@lists.denx.de, u-boot-qcom@groups.io,
	Varadarajan Narayanan <quic_varada@quicinc.com>,
	Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>,
	Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Subject: Re: [PATCH v2 3/7] tools: add mkmbn tool for Qualcomm
Date: Wed, 4 Jun 2025 11:15:13 +0200	[thread overview]
Message-ID: <aEAOoYg_wFvkI66Y@linaro.org> (raw)
In-Reply-To: <20250602-b4-qcom-tooling-improvements-v2-3-c7d19c0d4a8b@linaro.org>

On Mon, Jun 02, 2025 at 06:10:54PM +0200, Casey Connolly wrote:
> This is a fork of qtestsign[1] with modifications to integrate with the
> U-Boot build system.

I think it would be good if the "library" part of qtestsign (cert.py,
elf.py, hashseg.py) would stay unmodified if possible, and you only add
a new frontend on top (mkmbn.py). This would simplify syncing upstream
changes in the future, e.g. should the v7 support get introduced at some
point.

Have you changed anything meaningful inside these three files? Copying
the original files back in I mostly see re-formatting at the moment,
which makes it hard to see what is different.

Thanks,
Stephan

  reply	other threads:[~2025-06-04  9:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 16:10 [PATCH v2 0/7] Qualcomm: teach the build system to emit signed ELF images Casey Connolly
2025-06-02 16:10 ` [PATCH v2 1/7] binman: add $(srctree)/tools to toolpath Casey Connolly
2025-06-02 16:10 ` [PATCH v2 2/7] binman: support building binman dtb when OF_UPSTREAM is enabled Casey Connolly
2025-06-02 16:10 ` [PATCH v2 3/7] tools: add mkmbn tool for Qualcomm Casey Connolly
2025-06-04  9:15   ` Stephan Gerhold [this message]
2025-06-04 11:14     ` Casey Connolly
2025-06-02 16:10 ` [PATCH v2 4/7] binman: add support for building Qualcomm signed MBN ELF images Casey Connolly
2025-06-02 16:10 ` [PATCH v2 5/7] configs: qualcomm: use fragments for debug UART Casey Connolly
2025-06-02 16:10 ` [PATCH v2 6/7] configs: qualcomm: use mkmbn and stop creating ELF files Casey Connolly
2025-06-04  9:21   ` Stephan Gerhold
2025-06-04 11:17     ` Casey Connolly
2025-06-02 16:10 ` [PATCH v2 7/7] doc: board/qualcomm: update docs for new u-boot.mbn target Casey Connolly
2025-06-04  9:07 ` [PATCH v2 0/7] Qualcomm: teach the build system to emit signed ELF images Stephan Gerhold
2025-06-04 11:18   ` Casey Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEAOoYg_wFvkI66Y@linaro.org \
    --to=stephan.gerhold@linaro.org \
    --cc=aswin.murugan@oss.qualcomm.com \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_varada@quicinc.com \
    --cc=sumit.garg@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.