From: Zhao Liu <zhao1.liu@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] i386/tdx: Clarify the error message of mrconfigid/mrowner/mrownerconfig
Date: Wed, 4 Jun 2025 18:38:07 +0800 [thread overview]
Message-ID: <aEAiD9LOZKtoZSBx@intel.com> (raw)
In-Reply-To: <20250603050305.1704586-4-xiaoyao.li@intel.com>
On Tue, Jun 03, 2025 at 01:03:05AM -0400, Xiaoyao Li wrote:
> Date: Tue, 3 Jun 2025 01:03:05 -0400
> From: Xiaoyao Li <xiaoyao.li@intel.com>
> Subject: [PATCH 3/3] i386/tdx: Clarify the error message of
> mrconfigid/mrowner/mrownerconfig
> X-Mailer: git-send-email 2.43.0
>
> The error message is misleading - we successfully decoded the data,
> the decoded data was simply with the wrong length.
>
> Change the error message to show it is an length check failure with both
> the received and expected values.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> Suggested by Daniel at https://lore.kernel.org/qemu-devel/aBzT3TrdldaN-uqx@redhat.com/
> ---
> target/i386/kvm/tdx.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-06-04 10:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 5:03 [PATCH 0/3] TDX: Fix and enhancement Xiaoyao Li
2025-06-03 5:03 ` [PATCH 1/3] i386/cpu: Rename enable_cpuid_0x1f to force_cpuid_0x1f Xiaoyao Li
2025-06-03 8:31 ` Daniel P. Berrangé
2025-06-03 9:22 ` Igor Mammedov
2025-06-04 10:35 ` Zhao Liu
2025-06-03 5:03 ` [PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest Xiaoyao Li
2025-06-03 8:30 ` Daniel P. Berrangé
2025-06-03 9:24 ` Igor Mammedov
2025-06-04 10:36 ` Zhao Liu
2025-06-03 5:03 ` [PATCH 3/3] i386/tdx: Clarify the error message of mrconfigid/mrowner/mrownerconfig Xiaoyao Li
2025-06-03 8:30 ` Daniel P. Berrangé
2025-06-03 9:27 ` Igor Mammedov
2025-06-04 10:38 ` Zhao Liu [this message]
2025-06-17 18:02 ` [PATCH 0/3] TDX: Fix and enhancement Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEAiD9LOZKtoZSBx@intel.com \
--to=zhao1.liu@intel.com \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.