From: Alexey Gladkov <legion@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Petr Pavlu <petr.pavlu@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique
Date: Wed, 4 Jun 2025 13:26:09 +0200 [thread overview]
Message-ID: <aEAtUc6OTyvu-ThM@example.org> (raw)
In-Reply-To: <CAK7LNATfUzCXmCb5kKOJOKOw=CJvk7viGgYtrGLwbSAkq7VtyA@mail.gmail.com>
On Tue, Jun 03, 2025 at 01:18:25AM +0900, Masahiro Yamada wrote:
> > > > Before these patches this was not a problem as non-unique characters are
> > > > in separate object files when the module is compiled separately.
> > > >
> > > > But when the modules are compiled into the kernel, there is a symbol
> > > > conflict when linking vmlinuz. We have modules that export multiple device
> > > > tables from different object files.
> > >
> > > This is because the __mod_device_table__* symbols are global, but
> > > I suspect they do not need to be.
> > >
> > > Let's test this
> > > https://lore.kernel.org/lkml/20250602105539.392362-1-masahiroy@kernel.org/T/#u
> >
> > I tested this patch with the config:
> >
> > make allmodconfig
> > make mod2yesconfig
> >
> > and it works.
>
> Good.
> Then, __COUNTER__ is unnecessary.
I didn't immediately notice. The patch you suggested works, but these
symbols remain in System.map and it seems in vmlinuz.
--
Rgrds, legion
next prev parent reply other threads:[~2025-06-04 11:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 9:07 [PATCH v3 0/6] Add generated modalias to modules.builtin.modinfo Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary Alexey Gladkov
2025-05-27 11:28 ` James Bottomley
2025-05-27 11:54 ` Alexey Gladkov
2025-05-27 11:58 ` James Bottomley
2025-05-27 12:58 ` Alexey Gladkov
2025-05-27 14:06 ` [PATCH v4 1/6] scsi: Always define blogic_pci_tbl structure Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 2/6] modules: Add macros to specify modinfo prefix Alexey Gladkov
2025-06-02 7:49 ` Masahiro Yamada
2025-06-09 9:37 ` Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique Alexey Gladkov
2025-06-02 7:45 ` Masahiro Yamada
2025-06-02 8:06 ` Alexey Gladkov
2025-06-02 10:58 ` Masahiro Yamada
2025-06-02 14:03 ` Alexey Gladkov
2025-06-02 16:18 ` Masahiro Yamada
2025-06-02 17:09 ` Alexey Gladkov
2025-06-04 11:26 ` Alexey Gladkov [this message]
2025-06-06 5:10 ` Masahiro Yamada
2025-06-06 11:20 ` Masahiro Yamada
2025-06-02 7:52 ` Masahiro Yamada
2025-06-02 8:24 ` Alexey Gladkov
2025-06-02 18:00 ` Masahiro Yamada
2025-06-02 18:44 ` Alexey Gladkov
2025-06-06 5:12 ` Masahiro Yamada
2025-05-27 9:07 ` [PATCH v3 4/6] modpost: Create modalias for builtin modules Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 5/6] kbuild: Move modules.builtin.modinfo to another makefile Alexey Gladkov
2025-05-28 13:21 ` kernel test robot
2025-05-28 15:20 ` Alexey Gladkov
2025-05-27 9:08 ` [PATCH v3 6/6] kbuild: Create modules.builtin.modinfo for modpost results Alexey Gladkov
2025-05-27 13:15 ` [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE Alexey Gladkov
2025-05-27 13:22 ` James Bottomley
2025-05-27 13:44 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEAtUc6OTyvu-ThM@example.org \
--to=legion@kernel.org \
--cc=da.gomez@samsung.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.