Re: [PATCH v4 3/6] regulator: pf1550: add support for regulator

[Samuel Kayode <samuel.kayode@savoirfairelinux.com>]

On Wed, Jun 04, 2025 at 03:25:29PM +0100, Mark Brown wrote:
> On Wed, Jun 04, 2025 at 10:03:52AM -0400, Samuel Kayode wrote:
> > On Wed, Jun 04, 2025 at 12:35:21PM +0100, Mark Brown wrote:
> 
> > > > +	switch (irq_type) {
> > > > +	case PF1550_PMIC_IRQ_SW1_LS:
> > > > +		event = REGULATOR_EVENT_OVER_CURRENT;
> > > > +	case PF1550_PMIC_IRQ_SW1_HS:
> > > > +		event = REGULATOR_EVENT_OVER_CURRENT;
> > > > +	case PF1550_PMIC_IRQ_LDO1_FAULT:
> > > > +		event = REGULATOR_EVENT_OVER_CURRENT;
> 
> > > You appear to be flagging all these events as over current events which
> > > doesn't seem entirely plausible.
> 
> > It does seem like it but the manual describes these interrupts as "current limit
> > interrupt". The interrupts ending in _LS are "low-side current limit interrupt",
> > _HS are "high-side current limit interrupt" and _FAULT are "current limit fault
> > interrupt".
> 
> That at least needs some comments I think, and for the _LS while it's
> hard to parse what "low side" means my guess would be that it's a
> warning to match the other interrupt being the actual error.

Yes, It certainly does need comments. The high-side sensing is more accurate
and can detect load shorts, so a warning for low side would be more appropriate.

Thanks,
Sam