From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 274AEC5B543 for ; Wed, 4 Jun 2025 15:31:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1005694.1385111 (Exim 4.92) (envelope-from ) id 1uMq4k-0004G2-7x; Wed, 04 Jun 2025 15:30:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1005694.1385111; Wed, 04 Jun 2025 15:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uMq4k-0004Fv-4x; Wed, 04 Jun 2025 15:30:46 +0000 Received: by outflank-mailman (input) for mailman id 1005694; Wed, 04 Jun 2025 15:30:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uMq4j-0004Fp-Bz for xen-devel@lists.xenproject.org; Wed, 04 Jun 2025 15:30:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uMq4i-001xey-2y; Wed, 04 Jun 2025 15:30:44 +0000 Received: from lfbn-gre-1-199-136.w90-112.abo.wanadoo.fr ([90.112.161.136] helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uMq4j-002VFC-0F; Wed, 04 Jun 2025 15:30:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=DRLG+PyVcgEL1nJqbsbEqw1b4C7pXgsy8kpVYFM30VM=; b=KNOrvLUS6IVNltpBYGObCszLkk Mim9aD4rUyBSTbYnAqAVi58ImaS9W+dg4CB0igHPtH2YEz7rTn9ptelQLG3Xyoei6Blf+JBXQUpva bW4KG/4hOhb8TzfoLEj47hhGhQ0rzPqbHN0eWDdMHrqBZqVRot+MOF+BG3JXW6xD5fMc=; Date: Wed, 4 Jun 2025 17:30:42 +0200 From: Anthony PERARD To: Ross Lagerwall Cc: xen-devel@lists.xenproject.org, Anthony PERARD , Juergen Gross , Jan Beulich Subject: Re: [PATCH v3 4/5] libxc/PM: Ensure pxstat buffers are correctly sized Message-ID: References: <20250527152635.2451449-1-ross.lagerwall@citrix.com> <20250527152635.2451449-5-ross.lagerwall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250527152635.2451449-5-ross.lagerwall@citrix.com> On Tue, May 27, 2025 at 04:26:34PM +0100, Ross Lagerwall wrote: > diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c > index ff7b5ada053f..0bd79031044f 100644 > --- a/tools/libs/ctrl/xc_pm.c > +++ b/tools/libs/ctrl/xc_pm.c > @@ -46,35 +46,34 @@ int xc_pm_get_pxstat(xc_interface *xch, int cpuid, struct xc_px_stat *pxpt) > { > struct xen_sysctl sysctl = {}; > /* Sizes unknown until xc_pm_get_max_px */ This comment is wrong now and can be removed. > - DECLARE_NAMED_HYPERCALL_BOUNCE(trans, pxpt->trans_pt, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); > - DECLARE_NAMED_HYPERCALL_BOUNCE(pt, pxpt->pt, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); > + DECLARE_NAMED_HYPERCALL_BOUNCE(trans, pxpt->trans_pt, > + pxpt->total * pxpt->total * sizeof(uint64_t), > + XC_HYPERCALL_BUFFER_BOUNCE_BOTH); > + DECLARE_NAMED_HYPERCALL_BOUNCE(pt, pxpt->pt, > + pxpt->total * sizeof(struct xc_px_val), > + XC_HYPERCALL_BUFFER_BOUNCE_BOTH); The rest of the patch looks fine: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD