From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>,
Cleber Rosa <crosa@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v5 4/6] python: add qapi static analysis tests
Date: Thu, 5 Jun 2025 09:36:41 +0100 [thread overview]
Message-ID: <aEFXGXhqHkIioTOH@redhat.com> (raw)
In-Reply-To: <87frgen1dj.fsf@pond.sub.org>
On Thu, Jun 05, 2025 at 08:33:44AM +0200, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
>
> [...]
>
> > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh
> > new file mode 100755
> > index 00000000000..2211b6c7f41
> > --- /dev/null
> > +++ b/python/tests/qapi-flake8.sh
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh -e
> > +# SPDX-License-Identifier: LGPL-2.1-or-later
>
> Why not GPL-2.0-or-later?
Indeed, checkpatch.pl should be warning about this choice, and requesting
that it be explained in the commit message.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-06-05 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 20:03 [PATCH v5 0/6] python: add QAPI and qapidoc et al to python tests John Snow
2025-06-04 20:03 ` [PATCH v5 1/6] qapi: Add some pylint ignores John Snow via
2025-06-04 20:03 ` [PATCH v5 2/6] docs/qapidoc: linting fixes John Snow
2025-06-04 20:03 ` [PATCH v5 3/6] python: update missing dependencies from minreqs John Snow
2025-06-04 20:03 ` [PATCH v5 4/6] python: add qapi static analysis tests John Snow
2025-06-05 6:30 ` Markus Armbruster
2025-06-05 6:33 ` Markus Armbruster
2025-06-05 8:36 ` Daniel P. Berrangé [this message]
2025-06-05 16:02 ` John Snow
2025-06-04 20:03 ` [PATCH v5 5/6] python: Drop redundant warn_unused_configs = True John Snow
2025-06-04 20:03 ` [PATCH v5 6/6] qapi: delete un-needed python static analysis configs John Snow
2025-06-05 6:35 ` [PATCH v5 0/6] python: add QAPI and qapidoc et al to python tests Markus Armbruster
2025-06-05 16:00 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEFXGXhqHkIioTOH@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.