All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stewart Hildebrand <stewart.hildebrand@amd.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 2/5] vpci: rework error path in vpci_process_pending()
Date: Thu, 5 Jun 2025 11:53:05 +0200	[thread overview]
Message-ID: <aEFpARzSGJjFCjN1@macbook.local> (raw)
In-Reply-To: <20250531125405.268984-3-stewart.hildebrand@amd.com>

On Sat, May 31, 2025 at 08:54:00AM -0400, Stewart Hildebrand wrote:
> This will make further refactoring simpler.

I think you want to add:

No functional change intended.

To the commit message.

> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

The success and error paths have some shared code, that might be good
to unify, but that requires further rework.

Thanks, Roger.


  reply	other threads:[~2025-06-05  9:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-31 12:53 [PATCH v1 0/5] vpci: allow 32-bit BAR writes with memory decoding enabled Stewart Hildebrand
2025-05-31 12:53 ` [PATCH v1 1/5] vpci: const-ify some pdev instances Stewart Hildebrand
2025-06-05  9:47   ` Roger Pau Monné
2025-06-11 19:28     ` Stewart Hildebrand
2025-07-07 16:27       ` Stewart Hildebrand
2025-05-31 12:54 ` [PATCH v1 2/5] vpci: rework error path in vpci_process_pending() Stewart Hildebrand
2025-06-05  9:53   ` Roger Pau Monné [this message]
2025-06-11 20:44     ` Stewart Hildebrand
2025-05-31 12:54 ` [PATCH v1 3/5] vpci: introduce map_bars() Stewart Hildebrand
2025-06-05 10:16   ` Roger Pau Monné
2025-06-11 19:55     ` Stewart Hildebrand
2025-05-31 12:54 ` [PATCH v1 4/5] vpci: use separate rangeset for BAR unmapping Stewart Hildebrand
2025-06-05 10:28   ` Roger Pau Monné
2025-06-05 10:38   ` Jan Beulich
2025-05-31 12:54 ` [PATCH v1 5/5] vpci: allow 32-bit BAR writes with memory decoding enabled Stewart Hildebrand
2025-06-05 10:41   ` Jan Beulich
2025-06-11 20:22     ` Stewart Hildebrand
2025-06-12  7:27       ` Jan Beulich
2025-06-12  7:32     ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEFpARzSGJjFCjN1@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=stewart.hildebrand@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.