All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: xen-devel@lists.xenproject.org, Huang Rui <ray.huang@amd.com>,
	Anthony PERARD <anthony.perard@vates.tech>
Subject: Re: [PATCH v5 07/10] vpci: Refactor vpci_remove_register to remove matched registers
Date: Thu, 5 Jun 2025 17:00:50 +0200	[thread overview]
Message-ID: <aEGxIjIApdSumCQJ@macbook.local> (raw)
In-Reply-To: <20250526094559.140423-8-Jiqian.Chen@amd.com>

On Mon, May 26, 2025 at 05:45:56PM +0800, Jiqian Chen wrote:
> vpci_remove_register() only supports removing a register in a time,
> but the follow-on changes need to remove all registers within a range.
> So, refactor it to support removing all matched registers in a calling

"So, refactor it to support removing all registers in a given region."

> time.
> 
> And it is no matter to remove a non exist register, so remove the

s/no matter/no issue/

> __must_check prefix.
> 
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.


  reply	other threads:[~2025-06-05 15:01 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26  9:45 [PATCH v5 00/10] Support hiding capability when its initialization fails Jiqian Chen
2025-05-26  9:45 ` [PATCH v5 01/10] vpci/header: Move emulating cap list logic into new function Jiqian Chen
2025-05-26  9:45 ` [PATCH v5 02/10] vpci/header: Emulate legacy capability list for dom0 Jiqian Chen
2025-06-05 10:54   ` Roger Pau Monné
2025-05-26  9:45 ` [PATCH v5 03/10] vpci/header: Emulate extended " Jiqian Chen
2025-06-05 11:24   ` Roger Pau Monné
2025-06-06  4:05     ` Chen, Jiqian
2025-05-26  9:45 ` [PATCH v5 04/10] vpci: Refactor REGISTER_VPCI_INIT Jiqian Chen
2025-06-05 12:50   ` Roger Pau Monné
2025-06-05 12:59     ` Jan Beulich
2025-06-06  6:29     ` Chen, Jiqian
2025-06-06  7:05       ` Jan Beulich
2025-06-06  9:14         ` Roger Pau Monné
2025-06-09  7:50           ` Chen, Jiqian
2025-06-09  9:29             ` Roger Pau Monné
2025-06-09 10:18               ` Chen, Jiqian
2025-06-09 10:40                 ` Roger Pau Monné
2025-06-10  3:52                   ` Chen, Jiqian
2025-06-10  7:08                     ` Jan Beulich
2025-06-10  9:03                       ` Chen, Jiqian
2025-06-11 10:19                       ` Chen, Jiqian
2025-06-11 10:57                         ` Roger Pau Monné
2025-05-26  9:45 ` [PATCH v5 05/10] vpci: Hide legacy capability when it fails to initialize Jiqian Chen
2025-06-05 13:35   ` Roger Pau Monné
2025-06-06  7:03     ` Chen, Jiqian
2025-06-06  9:16       ` Roger Pau Monné
2025-05-26  9:45 ` [PATCH v5 06/10] vpci: Hide extended " Jiqian Chen
2025-06-05 14:47   ` Roger Pau Monné
2025-06-06  8:30     ` Chen, Jiqian
2025-06-06  9:18       ` Roger Pau Monné
2025-05-26  9:45 ` [PATCH v5 07/10] vpci: Refactor vpci_remove_register to remove matched registers Jiqian Chen
2025-06-05 15:00   ` Roger Pau Monné [this message]
2025-05-26  9:45 ` [PATCH v5 08/10] vpci/rebar: Free Rebar resources when init_rebar() fails Jiqian Chen
2025-06-05 15:14   ` Roger Pau Monné
2025-06-06  8:32     ` Chen, Jiqian
2025-06-06  9:20       ` Roger Pau Monné
2025-05-26  9:45 ` [PATCH v5 09/10] vpci/msi: Free MSI resources when init_msi() fails Jiqian Chen
2025-06-05 15:19   ` Roger Pau Monné
2025-06-06  8:38     ` Chen, Jiqian
2025-06-06  9:21       ` Roger Pau Monné
2025-05-26  9:45 ` [PATCH v5 10/10] vpci/msix: Free MSIX resources when init_msix() fails Jiqian Chen
2025-06-05 15:34   ` Roger Pau Monné
2025-06-06  8:44     ` Chen, Jiqian
2025-06-06  9:23       ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEGxIjIApdSumCQJ@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=anthony.perard@vates.tech \
    --cc=ray.huang@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.