Re: [PATCH 2/6] perf annotate: Remove __annotation_line__write()

[Namhyung Kim <namhyung@kernel.org>]

Hi Arnaldo,

On Thu, Jun 05, 2025 at 04:59:51PM -0300, Arnaldo Carvalho de Melo wrote:
> On Thu, Jun 05, 2025 at 04:55:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Sat, May 31, 2025 at 11:52:58PM -0700, Namhyung Kim wrote:
> > > Get rid of the internal function and convert function arguments into
> > > local variables if they are used more then twice.
> > 
> > "more than once"? "twice or more"?
> 
> Well, its "more than twice", as you did:
> 
> -               if (change_color)
> +               if (wops->change_color)
>                         color = obj__set_color(obj, HE_COLORSET_ADDR);
>                 obj__printf(obj, bf);
> -               if (change_color)
> +               if (wops->change_color)
>                         obj__set_color(obj, color);
> 
> Ok, I wouldn't touch this, i.e. would leave all as local variables that
> way the patch would be smaller :-)

I see.

> 
> So its just 'then once' to 'than once' the fixup.

Oops, will fix in v2.

Thanks,
Namhyung