All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pooja Katiyar <pooja.katiyar@intel.com>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	heikki.krogerus@linux.intel.com
Subject: Re: [PATCH 2/3] usb: typec: ucsi: Enable debugfs for message_out data structure
Date: Fri, 6 Jun 2025 12:03:26 +0300	[thread overview]
Message-ID: <aEKu3qgoRvJvyxxe@smile.fi.intel.com> (raw)
In-Reply-To: <faff193e6dbe86ed3076d425f0cb91e28e5739fc.1749142912.git.pooja.katiyar@intel.com>

On Thu, Jun 05, 2025 at 06:38:14PM -0700, Pooja Katiyar wrote:
> Add debugfs entry for writing message_out data structure to handle
> UCSI 2.1 and 3.0 commands through debugfs interface.
> 
> Users writing to the message_out debugfs file should ensure the input
> data adheres to the following format:
> 1. Input must be a non-empty valid hexadecimal string.
> 2. Input length of hexadecimal string must not exceed 256 bytes of
>    length to be in alignment with the message out data structure size
>    as per the UCSI specification v2.1.
> 3. If the input string length is odd, then user needs to prepend a
>    '0' to the first character for proper hex conversion.
> 
> Below are examples of valid hex strings. Note that these values are
> just examples. The exact values depend on specific command use case.
> 
> 	#echo 1A2B3C4D > message_out
> 	#echo 01234567 > message_out

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-06-06  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06  1:38 [PATCH 0/3] usb: typec: ucsi: Add support for SET_PDOS command Pooja Katiyar
2025-06-06  1:38 ` [PATCH 1/3] usb: typec: ucsi: Add support for message out data structure Pooja Katiyar
2025-06-06  1:38 ` [PATCH 2/3] usb: typec: ucsi: Enable debugfs for message_out " Pooja Katiyar
2025-06-06  9:03   ` Andy Shevchenko [this message]
2025-06-06  1:38 ` [PATCH 3/3] usb: typec: ucsi: Add support for SET_PDOS command Pooja Katiyar
2025-06-06  3:24   ` Dmitry Baryshkov
2025-06-11  8:52     ` Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2026-03-18 22:25 [PATCH 0/3] " Pooja Katiyar
2026-03-18 22:25 ` [PATCH 2/3] usb: typec: ucsi: Enable debugfs for message_out data structure Pooja Katiyar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEKu3qgoRvJvyxxe@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pooja.katiyar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.