All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] tst_atomic: drop legacy inline assembly and use __atomic or __sync builtins
Date: Fri, 6 Jun 2025 11:18:22 +0200	[thread overview]
Message-ID: <aEKyXpEg3NoPKLfq@yuki.lan> (raw)
In-Reply-To: <20250605120702.213048-1-liwang@redhat.com>

Hi!
> Refactor tst_atomic.h to remove all legacy architecture-specific inline
> assembly and fallback code paths. The new implementation supports only
> two well-defined interfaces: __atomic_* built-ins (GCC ≥ 4.7) and __sync_*
> built-ins (GCC ≥ 4.1).
> 
> This simplification improves maintainability, clarity, and portability
> across platforms. It also updates all function signatures to use int32_t
> for type consistency when operating on atomic counters, such as those in
> struct tst_results.

Can we please split the patch into the removal of the assembly and
separate patch that changes the types?

Also do we need to update fuzzy sync library in the second patch in
order not to produce warnings?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2025-06-06  9:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 12:07 [LTP] [PATCH v2 1/2] tst_atomic: drop legacy inline assembly and use __atomic or __sync builtins Li Wang via ltp
2025-06-05 12:07 ` [LTP] [PATCH v2 2/2] lib: moves test infrastructure states into a shared context structure Li Wang via ltp
2025-06-05 12:20   ` Li Wang via ltp
2025-06-06  9:18 ` Cyril Hrubis [this message]
2025-06-06  9:36   ` [LTP] [PATCH v2 1/2] tst_atomic: drop legacy inline assembly and use __atomic or __sync builtins Li Wang via ltp
2025-06-06 10:10     ` Li Wang via ltp
2025-06-06 10:16       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEKyXpEg3NoPKLfq@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.