All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Santos <jonath4nns@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Santos <Jonathan.Santos@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
	nuno.sa@analog.com, Michael.Hennerich@analog.com,
	marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	marcelo.schmitt1@gmail.com, linus.walleij@linaro.org,
	brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org,
	dlechner@baylibre.com,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support
Date: Fri, 6 Jun 2025 16:37:52 -0300	[thread overview]
Message-ID: <aENDkMN597fGsTL0@JSANTO12-L01.ad.analog.com> (raw)
In-Reply-To: <aEEzZjfLVUW1kyC9@smile.fi.intel.com>

On 06/05, Andy Shevchenko wrote:
> On Wed, Jun 04, 2025 at 04:36:43PM -0300, Jonathan Santos wrote:
> > From: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
> > 
> > The AD7768-1 has the ability to control other local hardware (such as gain
> > stages),to power down other blocks in the signal chain, or read local
> > status signals over the SPI interface.
> > 
> > Add direct mode conditional locks in the gpio callbacks to prevent register
> 
> GPIO
> 
> > access when the device is in buffered mode.
> > 
> > This change exports the AD7768-1's four gpios and makes them accessible
> 
> GPIOs
> 
> > at an upper layer.
> 
> ...
> 
> I haven't seen in the commit message nor in the comments why GPIO regmap can't
> be used. (No need to resend, just reply here, but keep in mind in case of a new
> version of the series.)
>

We did discussed this, see [1] and [2]. It would need a few tweaks on
the gpio regmap driver, but I will keep that in mind, thanks.

[1]: https://lore.kernel.org/linux-iio/7c5e2364-038b-48a8-ad67-3cf0f2fd2be3@baylibre.com/
[2]: https://lore.kernel.org/linux-iio/ddb448f0-1cfc-497b-ac1f-9f3d9e9fcc3a@baylibre.com/

> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

  reply	other threads:[~2025-06-06 19:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 19:35 [PATCH v10 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-06-04 19:35 ` [PATCH v10 01/12] iio: adc: ad7768-1: Ensure SYNC_IN pulse minimum timing requirement Jonathan Santos
2025-06-04 20:14   ` David Lechner
2025-06-07 12:22     ` Jonathan Cameron
2025-06-04 19:35 ` [PATCH v10 02/12] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-06-04 19:35 ` [PATCH v10 03/12] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 04/12] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-06-07 12:28   ` Jonathan Cameron
2025-06-04 19:36 ` [PATCH v10 05/12] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 06/12] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-06-05  6:04   ` Andy Shevchenko
2025-06-06 19:37     ` Jonathan Santos [this message]
2025-06-04 19:36 ` [PATCH v10 08/12] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-06-05  6:06   ` Andy Shevchenko
2025-06-04 19:37 ` [PATCH v10 09/12] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-06-05  6:10   ` Andy Shevchenko
2025-06-07 12:20     ` Jonathan Cameron
2025-06-04 19:37 ` [PATCH v10 10/12] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-06-04 19:37 ` [PATCH v10 11/12] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-06-05  6:21   ` Andy Shevchenko
2025-06-04 19:37 ` [PATCH v10 12/12] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-06-05  6:14   ` Andy Shevchenko
2025-06-05  6:23 ` [PATCH v10 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Andy Shevchenko
2025-06-07 12:34   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aENDkMN597fGsTL0@JSANTO12-L01.ad.analog.com \
    --to=jonath4nns@gmail.com \
    --cc=Jonathan.Santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=ddb448f0-1cfc-497b-ac1f-9f3d9e9fcc3a@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=sergiu.cuciurean@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.