From: Danilo Krummrich <dakr@kernel.org>
To: Igor Korotin <igor.korotin.linux@gmail.com>
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu, lenb@kernel.org,
wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com,
dingxiangfei2009@gmail.com
Subject: Re: [PATCH v3 3/4] rust: platform: Add ACPI match table support to `Driver` trait
Date: Sun, 8 Jun 2025 12:58:29 +0200 [thread overview]
Message-ID: <aEVs1Q5eYuOgVBi4@pollux> (raw)
In-Reply-To: <20250606170905.3881900-1-igor.korotin.linux@gmail.com>
On Fri, Jun 06, 2025 at 06:09:05PM +0100, Igor Korotin wrote:
> @@ -144,6 +150,7 @@ macro_rules! module_platform_driver {
> /// impl platform::Driver for MyDriver {
> /// type IdInfo = ();
> /// const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>> = Some(&OF_TABLE);
> +/// const ACPI_ID_TABLE: Option<acpi::IdTable<Self::IdInfo>> = Some(&ACPI_TABLE);
This breaks the doctest. You need to define ACPI_TABLE above, just like OF_TABLE
is defined above.
If you enable CONFIG_RUST_KERNEL_DOCTESTS=y it will compile the doctests and run
them as kunit test.
next prev parent reply other threads:[~2025-06-08 10:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 17:03 [PATCH v3 0/4] rust: Add ACPI match table support for Rust drivers Igor Korotin
2025-06-06 17:06 ` [PATCH v3 1/4] rust: acpi: add `acpi::DeviceId` abstraction Igor Korotin
2025-06-08 7:48 ` Benno Lossin
2025-06-08 10:42 ` Danilo Krummrich
2025-06-06 17:08 ` [PATCH v3 2/4] rust: driver: Add ACPI id table support to Adapter trait Igor Korotin
2025-06-08 7:54 ` Benno Lossin
2025-06-08 10:48 ` Danilo Krummrich
2025-06-08 11:46 ` Benno Lossin
2025-06-08 11:49 ` Danilo Krummrich
2025-06-09 13:09 ` Igor Korotin
2025-06-09 13:42 ` Miguel Ojeda
[not found] ` <CAG7QV91u4rVgAqDjKAofupASSk9q0uRKNtsrHg7Q6KExRMkFog@mail.gmail.com>
2025-06-09 14:06 ` Igor Korotin
2025-06-09 14:50 ` Miguel Ojeda
2025-06-09 14:44 ` Benno Lossin
2025-06-06 17:09 ` [PATCH v3 3/4] rust: platform: Add ACPI match table support to `Driver` trait Igor Korotin
2025-06-07 6:28 ` kernel test robot
2025-06-08 10:58 ` Danilo Krummrich [this message]
2025-06-06 17:10 ` [PATCH v3 4/4] samples: rust: add ACPI match table example to platform driver Igor Korotin
2025-06-08 7:58 ` Benno Lossin
2025-06-08 10:50 ` Danilo Krummrich
2025-06-08 11:08 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEVs1Q5eYuOgVBi4@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex.hung@amd.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dingxiangfei2009@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.