From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E766C5AD49 for ; Sun, 8 Jun 2025 21:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r5O3GGyj22Nz5ANTjCRm7B1kkachsO6UHRBJHaw/lss=; b=COUlLJ701oFoRZ6Djvg4Sazdmy gAg0nptEf91whk2Ut6PDgRz1v6uf8/BDnKXyLHpCTevVRMuPSzQ/BiTPMTiepXpFhtASKYU3zDHAR CaCuGkDOAbpbQre6ua9p7aBmOTfIfHEUzvAFX+NKQrRj879Nd7wYVJpSTrxHY3dR55UQMUIAVxv5K 4cEaKnNPp7eRgsJQmwLgprAUZF1SVVQ5iksvzm05H/h3ShbnOXpwCrnbR68XbOoJmUxu+mZgPoqLl yKggyJC0JzZIaY4bNr3oBr7R/XYdiVx4BmHL1oCKNL2OZSACu0IWhdVZJqTZLNmm17Rpgrr2GQ2mp sNWprEYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uONti-0000000324N-1txq; Sun, 08 Jun 2025 21:49:46 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uONVf-00000002ziO-3Ujf; Sun, 08 Jun 2025 21:24:57 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1uONMs-000000006CU-2z4t; Sun, 08 Jun 2025 21:24:32 +0000 Date: Sun, 8 Jun 2025 23:24:15 +0200 From: Daniel Golle To: Frank Wunderlich Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Jia-Wei Chang , Johnson Wang , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Landen Chao , DENG Qingfang , Sean Wang , Lorenzo Bianconi , Felix Fietkau , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 06/13] arm64: dts: mediatek: mt7988: add basic ethernet-nodes Message-ID: References: <20250608211452.72920-1-linux@fw-web.de> <20250608211452.72920-7-linux@fw-web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250608211452.72920-7-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250608_142455_868614_1E8B2DEA X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 08, 2025 at 11:14:39PM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add basic ethernet related nodes. > > Mac1+2 needs pcs (sgmii+usxgmii) to work correctly which will be linked > later when driver is merged. > > Signed-off-by: Daniel Golle > Signed-off-by: Frank Wunderlich > --- > arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 124 +++++++++++++++++++++- > 1 file changed, 121 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > index 560ec86dbec0..ee1e01d720fe 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > + > + eth: ethernet@15100000 { > + compatible = "mediatek,mt7988-eth"; > + reg = <0 0x15100000 0 0x80000>, > + <0 0x15400000 0 0x200000>; > + interrupts = , > + , > + , > + ; It would be better to use MT7988 with RSS and add the additional interrupts for doing so before introducing support for this SoC without RSS. In this way we would avoid having to deal with keeping the DT support compatible with the old (ie. 4 IRQs) way while also supporting the RSS-way (with a total of 8 IRQs). Alternatively, if we really want to support MT7988 with and without RSS we should use 'interrupt-names' instead of unnamed interrupts imho. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80FCEC5B552 for ; Sun, 8 Jun 2025 21:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r5O3GGyj22Nz5ANTjCRm7B1kkachsO6UHRBJHaw/lss=; b=vHOL5hq4/3VssBsr1IEYCxuGKg 5zUBC7eJLVnybSbOZOeTfkS0mwQ9+AsvEa42aEHbqwBsrp03X0Rvjyju77kxUzxetUX8m7LfG7rCf y6lI46x4NHdxe162DkFj9CaHZUHUYEctymorjXATHO4j2OXv+ixrgNlZO3IlA030rAFkrIvHCIrMT Leyo+ngEptcJAGGpOhOfsmF6QllNPeSb5adTEAeL7599kBt7g/OSAmFblpeTZL1H7p6z/ano/Gw34 2HGtUFOoTonBZiFoPKzXUj14Cx+VTIo5Nx6NoZpAcyqqBhAxzmRr+vjd9xfv1WAY2LP2WoPYFEjef EpVuNhXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uONti-0000000324S-3yIx; Sun, 08 Jun 2025 21:49:46 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uONVf-00000002ziO-3Ujf; Sun, 08 Jun 2025 21:24:57 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1uONMs-000000006CU-2z4t; Sun, 08 Jun 2025 21:24:32 +0000 Date: Sun, 8 Jun 2025 23:24:15 +0200 From: Daniel Golle To: Frank Wunderlich Subject: Re: [PATCH v3 06/13] arm64: dts: mediatek: mt7988: add basic ethernet-nodes Message-ID: References: <20250608211452.72920-1-linux@fw-web.de> <20250608211452.72920-7-linux@fw-web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250608211452.72920-7-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250608_142455_868614_1E8B2DEA X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Landen Chao , Eric Dumazet , Rob Herring , linux-pm@vger.kernel.org, Chanwoo Choi , MyungJoo Ham , Johnson Wang , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi , devicetree@vger.kernel.org, Conor Dooley , Sean Wang , DENG Qingfang , linux-mediatek@lists.infradead.org, Matthias Brugger , Jia-Wei Chang , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Georgi Djakov , Krzysztof Kozlowski , Vladimir Oltean , "David S. Miller" , Felix Fietkau Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Jun 08, 2025 at 11:14:39PM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add basic ethernet related nodes. > > Mac1+2 needs pcs (sgmii+usxgmii) to work correctly which will be linked > later when driver is merged. > > Signed-off-by: Daniel Golle > Signed-off-by: Frank Wunderlich > --- > arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 124 +++++++++++++++++++++- > 1 file changed, 121 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > index 560ec86dbec0..ee1e01d720fe 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > + > + eth: ethernet@15100000 { > + compatible = "mediatek,mt7988-eth"; > + reg = <0 0x15100000 0 0x80000>, > + <0 0x15400000 0 0x200000>; > + interrupts = , > + , > + , > + ; It would be better to use MT7988 with RSS and add the additional interrupts for doing so before introducing support for this SoC without RSS. In this way we would avoid having to deal with keeping the DT support compatible with the old (ie. 4 IRQs) way while also supporting the RSS-way (with a total of 8 IRQs). Alternatively, if we really want to support MT7988 with and without RSS we should use 'interrupt-names' instead of unnamed interrupts imho.