Re: [PATCH v5 20/29] x86,fs/resctrl: Fill in details of Clearwater Forest events

["Luck, Tony" <tony.luck@intel.com>]

On Fri, Jun 06, 2025 at 05:57:09PM -0700, Fenghua Yu wrote:
> > @@ -60,6 +78,11 @@ struct event_group {
> >   static struct event_group energy_0x26696143 = {
> >   	.guid		= 0x26696143,
> >   	.mmio_size	= (576 * 2 + 3) * 8,
> > +	.num_events	= 2,
> > +	.evts				= {
> Please align the "=" with the above "=".

Fixed.

> > +		EVT(PMT_EVENT_ENERGY, 0, 18),
> > +		EVT(PMT_EVENT_ACTIVITY, 1, 18),
> > +	}
> >   };
> >   /*
> > @@ -69,6 +92,16 @@ static struct event_group energy_0x26696143 = {
> >   static struct event_group perf_0x26557651 = {
> >   	.guid		= 0x26557651,
> >   	.mmio_size	= (576 * 7 + 3) * 8,
> > +	.num_events	= 7,
> > +	.evts				= {
> 
> Ditto.

Ditto fixed.

Thanks

-Tony