Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

[Mike Rapoport <rppt@kernel.org>]

On Mon, Jun 16, 2025 at 09:59:09AM +0200, David Hildenbrand wrote:
> On 16.06.25 04:29, Hao Ge wrote:
> > From: Hao Ge <gehao@kylinos.cn>
> 
> subject is misleading: we are not optimizing anything in this patch, do we?
> 
> It should probably be called
> 
> "mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEED_WEAK_PER_CPU" or
> sth. like that.
> 
> 
> > Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file
> > and enable it for the s390 and alpha architectures.
> > And replace all instances of ARCH_NEEDS_WEAK_PER_CPU
> > in the kernel code with MODULE_NEEDS_WEAK_PER_CPU.
> 
> Most of the description here should likely go to patch #2. See below.

...

> So what you could do is move the actual introduction of
> CONFIG_ARCH_NEEDS_WEAK_PER_CPU to patch #2, where it is actually used, and
> limit this patch to the rename.
> 
> Similarly, teak the patch description to reflect only that.

Right, if the patch only renames ARCH_NEEDS_WEAK_PER_CPU to
MODULE_NEEDS_WEAK_PER_CPU the description can be as simple as 

mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU

as a preparation for introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU.
No functional changes.
 
> -- 
> Cheers,
> 
> David / dhildenb
> 

-- 
Sincerely yours,
Mike.