All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Yi Chen <yiche@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] tests: shell: Add a test case for FTP helper combined with NAT.
Date: Mon, 9 Jun 2025 10:37:38 +0200	[thread overview]
Message-ID: <aEadUq1HYYoP2sbX@strlen.de> (raw)
In-Reply-To: <CAJsUoE38FbpdGGGMkjLOyc5z5bQt9hviex2UmD_zcHuWNhY1ew@mail.gmail.com>

Yi Chen <yiche@redhat.com> wrote:
> > Is tcpdump a requirement? AFAICS the dumps are only used
> > as a debug aid when something goes wrong?
> tcpdump is widely used in our LNST test cases. for example check if
> one packet got modified.
> Is it bad to use in upstream tests? If you still feel strange, I can
> remove the tcpdump check.

No need, you can keep tcpdump around.

> What I care about most is whether the ruleset in the test is
> configured correctly.
> One only needs to NAT the control connection — the data connection
> will be NATed automatically.

I'd have expected that the ftp connection would fail in case
there is a problem with NAT.

But if you prefer to also validate via tcpdump thats fine.

Thanks for v2, I will have a look.

  reply	other threads:[~2025-06-09  8:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 10:33 [PATCH] tests: shell: Add a test case for FTP helper combined with NAT Yi Chen
2025-06-05 10:49 ` [PATCH v2] " Yi Chen
2025-06-06 13:49   ` Florian Westphal
2025-06-06 16:47     ` Yi Chen
2025-06-09  8:37       ` Florian Westphal [this message]
2025-06-09  8:14 ` Yi Chen
2025-06-09 21:35   ` Florian Westphal
2025-06-10  4:05     ` Yi Chen
2025-06-10  6:02       ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEadUq1HYYoP2sbX@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=yiche@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.