From: Keith Busch <kbusch@kernel.org>
To: Anuj gupta <anuj1072538@gmail.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
shinichiro.kawasaki@wdc.com, axboe@kernel.dk
Subject: Re: [PATCH blktests] block tests: nvme metadata passthrough
Date: Mon, 9 Jun 2025 09:24:12 -0600 [thread overview]
Message-ID: <aEb8nNl73MFNd1Lu@kbusch-mbp> (raw)
In-Reply-To: <CACzX3AtTwR3dWpYw_jwWKTZziz251cb7xobgF2ta5WL6Kr2uBQ@mail.gmail.com>
On Fri, Jun 06, 2025 at 07:11:20AM +0530, Anuj gupta wrote:
> Minor nit: should use `.nsid = nsid` instead of hardcoded `1`
>
> > + /* This should not be mappable for write commands */
>
> Maybe reword this to:
> /* This buffer is read-only, so using it for write passthrough should fail */
> -- makes the intent clearer.
Err, I actually got this backwards. PROT_READ means we can write to the
disk from that memory, but we can't read from the disk into it.
next prev parent reply other threads:[~2025-06-09 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 0:30 [PATCH blktests] block tests: nvme metadata passthrough Keith Busch
2025-06-06 1:41 ` Anuj gupta
2025-06-09 15:24 ` Keith Busch [this message]
2025-06-07 12:54 ` Shinichiro Kawasaki
2025-06-08 19:55 ` Anuj gupta
2025-06-09 7:40 ` Shinichiro Kawasaki
2025-06-09 15:04 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEb8nNl73MFNd1Lu@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=anuj1072538@gmail.com \
--cc=axboe@kernel.dk \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.