From: Ido Schimmel <idosch@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH iproute2-next v2 1/4] ip: ipstats: Iterate all xstats attributes
Date: Tue, 10 Jun 2025 10:14:51 +0300 [thread overview]
Message-ID: <aEfba37PsZm8s99u@shredder> (raw)
In-Reply-To: <e8834ec759b3e7f94545fe07a219ca592e84e402.1749484902.git.petrm@nvidia.com>
On Mon, Jun 09, 2025 at 06:05:09PM +0200, Petr Machata wrote:
> ipstats_stat_desc_show_xstats() operates by first parsing the attribute
> stream into a type-indexed table, and then accessing the right attribute.
> But bridge VLAN stats are given as several BRIDGE_XSTATS_VLAN attributes,
> one per VLAN. With the above approach to parsing, only one of these
> attributes would be shown. Instead, iterate the stream of attributes and
> call the show_cb for each one with a matching type.
>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-06-10 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 16:05 [PATCH iproute2-next v2 0/4] ip: Support bridge VLAN stats in `ip stats' Petr Machata
2025-06-09 16:05 ` [PATCH iproute2-next v2 1/4] ip: ipstats: Iterate all xstats attributes Petr Machata
2025-06-10 7:14 ` Ido Schimmel [this message]
2025-06-10 12:20 ` Nikolay Aleksandrov
2025-06-09 16:05 ` [PATCH iproute2-next v2 2/4] ip: ip_common: Drop ipstats_stat_desc_xstats::inner_max Petr Machata
2025-06-10 12:21 ` Nikolay Aleksandrov
2025-06-09 16:05 ` [PATCH iproute2-next v2 3/4] lib: bridge: Add a module for bridge-related helpers Petr Machata
2025-06-10 7:16 ` Ido Schimmel
2025-06-10 12:21 ` Nikolay Aleksandrov
2025-06-09 16:05 ` [PATCH iproute2-next v2 4/4] ip: iplink_bridge: Support bridge VLAN stats in `ip stats' Petr Machata
2025-06-10 7:22 ` Ido Schimmel
2025-06-10 13:14 ` Petr Machata
2025-06-10 12:21 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEfba37PsZm8s99u@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.