From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: host: renesas_sdhi: Fix incorrect auto retuning for an SDIO card
Date: Tue, 10 Jun 2025 10:24:05 +0200 [thread overview]
Message-ID: <aEfrpUA7WsyiOjX1@ninjato> (raw)
In-Reply-To: <20250610072545.2001435-3-yoshihiro.shimoda.uh@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Tue, Jun 10, 2025 at 04:25:45PM +0900, Yoshihiro Shimoda wrote:
> This host controller is possible to change incorrect tap if an SDIO
> card is used because DAT1 is used for interrupt signal on SDIO standard
> but the controller doesn't take care of it. So, in the worst case,
> this behavior causes a CRC error.
>
> To resolve the issue, this driver uses manual correction mode instead
> of auto correction if an SDIO card is used. Also, even if DAT1 is
> mismatched on an SDIO card, this driver will not change the TAP.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I tested this with my uBlox EMMY card (SDR104) on a Salvator-XS (R-Car
M3N) and some debug output added. Works as expected:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-06-10 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 7:25 [PATCH 0/2] mmc: host: renesas_sdhi: Fix incorrect auto retuning for an SDIO card Yoshihiro Shimoda
2025-06-10 7:25 ` [PATCH 1/2] mmc: host: tmio: Add .sdio_irq() Yoshihiro Shimoda
2025-06-10 8:23 ` Wolfram Sang
2025-06-10 7:25 ` [PATCH 2/2] mmc: host: renesas_sdhi: Fix incorrect auto retuning for an SDIO card Yoshihiro Shimoda
2025-06-10 8:24 ` Wolfram Sang [this message]
2025-06-19 11:19 ` [PATCH 0/2] " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEfrpUA7WsyiOjX1@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.