From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
ikepanhc@gmail.com,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Armin Wolf" <W_Armin@gmx.de>,
linux-doc@vger.kernel.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
ibm-acpi-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling
Date: Tue, 10 Jun 2025 16:33:31 +0300 [thread overview]
Message-ID: <aEg0K1OE6zhL97me@smile.fi.intel.com> (raw)
In-Reply-To: <f3b5c138-5576-4c01-b177-7450f1e91d24@app.fastmail.com>
On Tue, Jun 10, 2025 at 08:28:49AM -0400, Mark Pearson wrote:
> On Tue, Jun 10, 2025, at 3:35 AM, Ilpo Järvinen wrote:
> > On Mon, 9 Jun 2025, Mark Pearson wrote:
...
> >> + serial = dmi_get_system_info(DMI_PRODUCT_SERIAL);
> >> + if (!serial)
> >> + return -EINVAL;
> >
> > This should not return -EINVAL as it is not a problem with the input
> > parameters. Perhaps -ENODEV would make sense instead?
>
> Good point.
> Unless Andy strongly thinks I should drop this bit, I'll fix in the next version
If maintainers are okay to take this approach (both Kconfig and C file
changes), I am fine.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-10 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 12:27 [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir Mark Pearson
2025-06-09 12:27 ` [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling Mark Pearson
2025-06-09 20:19 ` Andy Shevchenko
2025-06-10 1:26 ` Mark Pearson
2025-06-10 7:35 ` Ilpo Järvinen
2025-06-10 12:28 ` Mark Pearson
2025-06-10 13:33 ` Andy Shevchenko [this message]
2025-06-09 20:17 ` [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir Andy Shevchenko
2025-06-10 1:21 ` Mark Pearson
2025-06-10 10:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEg0K1OE6zhL97me@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.