From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Riyan Dhiman <riyandhiman14@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Paolo Perego <pperego@suse.de>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbtft: reduce stack usage
Date: Tue, 10 Jun 2025 13:53:27 +0300 [thread overview]
Message-ID: <aEgOpxYVSROvbpl_@smile.fi.intel.com> (raw)
In-Reply-To: <088dc0a1-fc54-478c-b253-4ed5dd6d6bae@app.fastmail.com>
On Tue, Jun 10, 2025 at 12:35:14PM +0200, Arnd Bergmann wrote:
> On Tue, Jun 10, 2025, at 12:26, Andy Shevchenko wrote:
> > On Tue, Jun 10, 2025 at 11:24:38AM +0200, Arnd Bergmann wrote:
...
> >> +static noinline_for_stack void fbtft_write_register_64(struct fbtft_par *par,
> >> + int i, int buf[64])
> >
> > Perhaps int i, int buf[64] should be u32?
>
> Right, I can send an updated patch, or this could be fixed up when applying
> the patch
Greg doesn't do that (or won't do anyway), so either a followup or a v2.
...
> > Wondering if we may reuse this in other cases (by providing the additional
> > length parameter). But it may be done later on.
>
> I tried this and that quickly became a mess. It is probably a good
> idea to rework the code to completely avoid the varargs function
> pointer and instead take an array here, but this is not something
> I could easily do myself as that takes more time and needs better
> testing.
Right and this driver in any case in a frozen position, so it might never
happen, though.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-06-10 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 9:24 [PATCH] fbtft: reduce stack usage Arnd Bergmann
2025-06-10 10:26 ` Andy Shevchenko
2025-06-10 10:35 ` Arnd Bergmann
2025-06-10 10:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEgOpxYVSROvbpl_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=pperego@suse.de \
--cc=riyandhiman14@gmail.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.