From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stewart Hildebrand <stewart.hildebrand@amd.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2] xen/arm: fix build with HAS_PCI
Date: Tue, 10 Jun 2025 17:51:23 +0200 [thread overview]
Message-ID: <aEhUe30Hojo8CoeP@macbook.local> (raw)
In-Reply-To: <20250610142300.197599-1-stewart.hildebrand@amd.com>
On Tue, Jun 10, 2025 at 10:22:57AM -0400, Stewart Hildebrand wrote:
> In file included from ./include/xen/pci.h:72,
> from drivers/pci/pci.c:8:
> ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 131 | static inline int pci_sanitize_bar_memory(struct rangeset *r)
> | ^~~~~~~~
> cc1: all warnings being treated as errors
>
> Fixes: 4acab25a9300 ("x86/vpci: fix handling of BAR overlaps with non-hole regions")
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
Sorry, it was my fault.
Would it make sense to introduce a Gitlab build that has HAS_PCI
enabled? Or it won't build either without extra patches?
Thanks, Roger.
next prev parent reply other threads:[~2025-06-10 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 14:22 [PATCH v2] xen/arm: fix build with HAS_PCI Stewart Hildebrand
2025-06-10 14:29 ` Orzel, Michal
2025-06-10 15:51 ` Roger Pau Monné [this message]
2025-06-10 16:16 ` Stewart Hildebrand
2025-06-10 16:32 ` Roger Pau Monné
2025-06-10 16:37 ` Andrew Cooper
2025-06-10 17:15 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEhUe30Hojo8CoeP@macbook.local \
--to=roger.pau@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=stewart.hildebrand@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.