From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] x86/HVM: restrict use of pinned cache attributes as well as associated flushing
Date: Tue, 10 Jun 2025 17:54:59 +0200 [thread overview]
Message-ID: <aEhVU3ZsJrBxRyZf@macbook.local> (raw)
In-Reply-To: <3470dcc8-f08a-4a00-8760-b3564d78e638@suse.com>
On Tue, Jun 10, 2025 at 04:13:40PM +0200, Jan Beulich wrote:
> On 10.06.2025 15:24, Roger Pau Monné wrote:
> > IMO the added complexity here is not worth the performance
> > improvement, not without a clear justification that it's needed.
>
> Well, okay, I'll simply consider the patch in this shape rejected then.
> I don't see much value in wasting further time on it.
The code is already there, so I think there's value in this patch.
Did you see my suggestion in the email yo uare replying to about not
needing to add the is_iommu_enabled(d) || cache_flush_permitted(d)
checks?
With that dropped (if it's indeed OK), I would be fine with Acking the
patch.
Thanks, Roger.
next prev parent reply other threads:[~2025-06-10 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 9:48 [PATCH v2] x86/HVM: restrict use of pinned cache attributes as well as associated flushing Jan Beulich
2025-06-09 10:36 ` Roger Pau Monné
2025-06-10 7:40 ` Jan Beulich
2025-06-10 10:44 ` Roger Pau Monné
2025-06-10 11:59 ` Jan Beulich
2025-06-10 13:24 ` Roger Pau Monné
2025-06-10 14:13 ` Jan Beulich
2025-06-10 15:54 ` Roger Pau Monné [this message]
2025-06-11 10:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEhVU3ZsJrBxRyZf@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.