Re: [PATCH 2/2] watchdog: generic name for i6300esb

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Jun 10, 2025 at 04:32:59PM +0200, Cornelia Huck wrote:
> The Intel 6300 Enterprise SouthBridge is a south bridge for a more or
> less obscure embedded Intel system; however, the i6300esb watchdog
> device we implement in QEMU is a virtual watchdog device that should
> work well on any PCI-based machine, is well supported by Linux guests,
> and used in many examples on how to set up a virtual watchdog.
> 
> Let's use "virtual i6300ESB" in the description to make clear that
> this device will work just fine on non-Intel platforms.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  hw/watchdog/wdt_i6300esb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm not entirely sold on the idea that this is needed, but at the same
time I won't object so

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> 
> diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
> index bb8a2766b69b..5e5d8c48cfd7 100644
> --- a/hw/watchdog/wdt_i6300esb.c
> +++ b/hw/watchdog/wdt_i6300esb.c
> @@ -472,7 +472,7 @@ static void i6300esb_class_init(ObjectClass *klass, const void *data)
>      device_class_set_legacy_reset(dc, i6300esb_reset);
>      dc->vmsd = &vmstate_i6300esb;
>      set_bit(DEVICE_CATEGORY_WATCHDOG, dc->categories);
> -    dc->desc = "Intel 6300ESB";
> +    dc->desc = "virtual i6300ESB";
>  }
>  
>  static const TypeInfo i6300esb_info = {
> -- 
> 2.49.0
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|