All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Eric Biggers <ebiggers@google.com>,
	Joel Granados <joel.granados@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random: use offstack cpumask when necessary
Date: Tue, 10 Jun 2025 11:33:46 -0600	[thread overview]
Message-ID: <aEhsekBWuP51sWRZ@zx2c4.com> (raw)
In-Reply-To: <20250610092712.2641547-1-arnd@kernel.org>

Hi Arnd,

On Tue, Jun 10, 2025 at 11:27:08AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The entropy generation function keeps a local cpu mask on the stack, which
> can trigger warnings in configurations with a large number of CPUs:
> 
> drivers/char/random.c:1292:20: error: stack frame size (1288) exceeds limit (1280) in 'try_to_generate_entropy' [-Werror,-Wframe-larger-than]
> 
> Use the cpumask interface to dynamically allocate it in those configurations.

Thanks. I hadn't seen this interface before. Applied with one nit fixed:

> +		goto out;;

Double semi-colon changed to single semi-colon.

Jason

  reply	other threads:[~2025-06-10 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  9:27 [PATCH] random: use offstack cpumask when necessary Arnd Bergmann
2025-06-10 17:33 ` Jason A. Donenfeld [this message]
2025-06-11  4:06 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEhsekBWuP51sWRZ@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=ebiggers@google.com \
    --cc=joel.granados@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.