From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: phasta@kernel.org
Cc: "Damien Le Moal" <dlemoal@kernel.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ata: pata_macio: Fix PCI region leak
Date: Tue, 10 Jun 2025 23:15:52 +0300 [thread overview]
Message-ID: <aEiSeFkgbmOY7ZVN@smile.fi.intel.com> (raw)
In-Reply-To: <aade5fcc5bae0e2a04441388fd7f248704a33ae3.camel@mailbox.org>
On Tue, Jun 10, 2025 at 04:01:43PM +0200, Philipp Stanner wrote:
> On Tue, 2025-06-10 at 15:54 +0200, Philipp Stanner wrote:
> > pci_request_regions() became a managed devres functions if the PCI
> > device was enabled with pcim_enable_device(), which is the case for
> > pata_macio.
> >
> > The PCI subsystem recently removed this hybrid feature from
> > pci_request_region(). When doing so, pata_macio was forgotten to be
> > ported to use pcim_request_all_regions(). If that function is not
> > used,
> > pata_macio will fail on driver-reload because the PCI regions will
> > remain blocked.
> >
> > Fix the region leak by replacing pci_request_regions() with its
> > managed
> > counterpart, pcim_request_all_regions().
> >
> > Fixes: 51f6aec99cb0 ("PCI: Remove hybrid devres nature from request
> > functions")
> > Signed-off-by: Philipp Stanner <phasta@kernel.org>
>
> Forgot Damien's Reviewed-by.
Then put it here, if maintainers use `b4`, it will automatically harvest them.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-10 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 13:54 [PATCH v2] ata: pata_macio: Fix PCI region leak Philipp Stanner
2025-06-10 14:01 ` Philipp Stanner
2025-06-10 20:15 ` Andy Shevchenko [this message]
2025-06-10 14:18 ` Sathyanarayanan Kuppuswamy
2025-06-11 10:31 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEiSeFkgbmOY7ZVN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.