From: Tejun Heo <tj@kernel.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: allison.henderson@oracle.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
guro@fb.com, kernel-team@fb.com, surenb@google.com,
peterz@infradead.org, hannes@cmpxchg.org, mkoutny@suse.com,
cgroups@vger.kernel.org, andrew@lunn.ch
Subject: Re: [rds-devel] [PATCH RFC v1] Feature reporting of RDS driver.
Date: Tue, 10 Jun 2025 11:32:40 -1000 [thread overview]
Message-ID: <aEikeOlAjvbqm_7v@slm.duckdns.org> (raw)
In-Reply-To: <aEiZ212HZo3-zpMc@char.us.oracle.com>
Hello,
On Tue, Jun 10, 2025 at 04:47:23PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 10, 2025 at 12:27:24PM -0400, Konrad Rzeszutek Wilk via rds-devel wrote:
> > Hi folks,
>
> Hi cgroup folks,
>
> Andrew suggested that I reach out to you all since you had implemented
> something very similar via:
>
> 3958e2d0c34e1
> 01ee6cfb1483f
>
> And I was wondering if you have have feedback on what worked for you,
> best practices, etc.
I don't know RDS at all, so please take what I say with a big grain of salt.
That said, the sysfs approach is pretty straightforward and has worked well
for us. One thing which we didn't do (yet) but maybe useful is defining some
conventions to tell whether a given feature or option should be enabled by
default so that most users don't have to know which features to use and
follow whatever the kernel release thinks is the best default combination.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-06-10 21:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 16:27 [PATCH RFC v1] Feature reporting of RDS driver Konrad Rzeszutek Wilk
2025-06-10 16:27 ` [PATCH RFC v1] rds: Expose feature parameters via sysfs and ELF note Konrad Rzeszutek Wilk
2025-06-10 20:30 ` Andrew Lunn
2025-06-10 20:41 ` Konrad Rzeszutek Wilk
2025-06-10 20:50 ` Andrew Lunn
2025-06-10 20:54 ` Konrad Rzeszutek Wilk
2025-06-10 20:51 ` Konrad Rzeszutek Wilk
2025-06-12 9:17 ` Leon Romanovsky
2025-06-10 20:47 ` [rds-devel] [PATCH RFC v1] Feature reporting of RDS driver Konrad Rzeszutek Wilk
2025-06-10 21:32 ` Tejun Heo [this message]
2025-06-10 23:15 ` Konrad Rzeszutek Wilk
2025-06-16 17:45 ` Tejun Heo
2025-06-10 21:09 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEikeOlAjvbqm_7v@slm.duckdns.org \
--to=tj@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=andrew@lunn.ch \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rds-devel@oss.oracle.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.