From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE695284B36; Wed, 11 Jun 2025 13:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749646972; cv=none; b=BBHwnwnzz/rRrBkC65d2VHgHDBaipx6S3XjTIyyD1hjP2HgtDLhYf7hB3XVOeLlJguYD/ZoT4v3FRnQoXCJoVj3/+aznvqFp4gJ+K2WsMUiAdWzBKSdWJqsLMgIcP4tfilHLTRF9/gXZ+K3TXRd96JhAq6KjETAUcqHmhgXMz8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749646972; c=relaxed/simple; bh=GWYTVxKC93YJVMhVzanm/CX1o4JT55CaAW87EgvJi2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ci+F7hVuPNhEddKSNmRNWvItHlBFK1kchnLJn9z90JZo/VQLwkNbWebqTN9ZUng9C8I7f2kJZPPcQTblSWPPrKFGCY5F6VLHvqNOmEe0clyjST1GfCZ6GlBOX93YuJdNrGvvzzUWy5EJjCmsB1/HYs7vfs8k4Vmxn5DkhgzKKxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hG2DfL5J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hG2DfL5J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1C76C4CEEE; Wed, 11 Jun 2025 13:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749646972; bh=GWYTVxKC93YJVMhVzanm/CX1o4JT55CaAW87EgvJi2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hG2DfL5JR+8qDvnZmSLi/lKndMr1EnbHqsT75jBCcqxPrs46YBWQs78lBKvfIE+aC Ft54mn2k1z/VL94FG/gGRpAFTrRaNC2WrIJddrIdSTxXBdhZ11poBFM5GyIKizdlje XLei3+O+DuE8lYoCRgHIF7PTD81y3M8EX7/gvgRuJe7aWmOSpRkCP450dZW1rVp1Z+ 271mRK0wm/Wxo+Pbymb6PpDzhp7/YZF5km8FQlnR2xbYKftcYV784uiCDkHso6pVrU yVZ1Vy0MKOlQ4a+FR2WvVC+7/32bydLAzh0g3S0E3MX5pQZwhALd++Sh1U+r04u37P Y8AgWtX7mANzQ== Date: Wed, 11 Jun 2025 18:32:43 +0530 From: Sumit Garg To: Amirreza Zarrabi Cc: Jens Wiklander , Bjorn Andersson , Konrad Dybcio , Bartosz Golaszewski , Apurupa Pattapu , Kees Cook , "Gustavo A. R. Silva" , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Harshal Dev , linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v5 05/12] tee: increase TEE_MAX_ARG_SIZE to 4096 Message-ID: References: <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-0-024e3221b0b9@oss.qualcomm.com> <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-5-024e3221b0b9@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-5-024e3221b0b9@oss.qualcomm.com> On Mon, May 26, 2025 at 11:56:50PM -0700, Amirreza Zarrabi wrote: > Increase TEE_MAX_ARG_SIZE to accommodate worst-case scenarios where > additional buffer space is required to pass all arguments to TEE. > This change is necessary for upcoming support for Qualcomm TEE, which > requires a larger buffer for argument marshaling. > > Signed-off-by: Amirreza Zarrabi > --- > include/uapi/linux/tee.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h > index 441d97add53f..71a365afb89b 100644 > --- a/include/uapi/linux/tee.h > +++ b/include/uapi/linux/tee.h > @@ -42,7 +42,7 @@ > #define TEE_IOC_MAGIC 0xa4 > #define TEE_IOC_BASE 0 > > -#define TEE_MAX_ARG_SIZE 1024 > +#define TEE_MAX_ARG_SIZE 4096 > > #define TEE_GEN_CAP_GP (1 << 0)/* GlobalPlatform compliant TEE */ > #define TEE_GEN_CAP_PRIVILEGED (1 << 1)/* Privileged device (for supplicant) */ > > -- > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63180C61CE7 for ; Wed, 11 Jun 2025 13:03:13 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id 91E16413F6 for ; Wed, 11 Jun 2025 13:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.trustedfirmware.org; s=2024; t=1749646992; bh=GWYTVxKC93YJVMhVzanm/CX1o4JT55CaAW87EgvJi2k=; h=Date:To:Subject:References:In-Reply-To:CC:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Reply-To:From; b=yjkdtM6mpLobSSFTJp5EH7cuYI8yNZrfXP7abFj/tr/30rKjsb/efUneJKQe4NYYq iYlm4mWQ5xwYis+xF2MvpOeWk0n8aoJCJ8kwgRwuSHQOt88oRlbsuoGzSupOFphK1X c75EYEdVjEoRgRbHK5PmU8AfFB3fm7fQkdAMSBNzfEIkmxRJ1ULJAooQrEAGfRqAng A46kQjeokQbNsbFfSuvBnn0Rf1fMNEQAp7p9cvlaET77A3wRL/sqbSCooWIC53ITpv c55BbYnO/yuPZPYs/6V7etWzEb/GhCGz59YYWebRHsQS87ZFiKxzQMvkGcldjmvRrj AwzBCeGN2rFvg== Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by lists.trustedfirmware.org (Postfix) with ESMTPS id CBE4B3F5BF for ; Wed, 11 Jun 2025 13:02:52 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hG2DfL5J; dkim-atps=neutral Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A1B61A4E5E3; Wed, 11 Jun 2025 13:02:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1C76C4CEEE; Wed, 11 Jun 2025 13:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749646972; bh=GWYTVxKC93YJVMhVzanm/CX1o4JT55CaAW87EgvJi2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hG2DfL5JR+8qDvnZmSLi/lKndMr1EnbHqsT75jBCcqxPrs46YBWQs78lBKvfIE+aC Ft54mn2k1z/VL94FG/gGRpAFTrRaNC2WrIJddrIdSTxXBdhZ11poBFM5GyIKizdlje XLei3+O+DuE8lYoCRgHIF7PTD81y3M8EX7/gvgRuJe7aWmOSpRkCP450dZW1rVp1Z+ 271mRK0wm/Wxo+Pbymb6PpDzhp7/YZF5km8FQlnR2xbYKftcYV784uiCDkHso6pVrU yVZ1Vy0MKOlQ4a+FR2WvVC+7/32bydLAzh0g3S0E3MX5pQZwhALd++Sh1U+r04u37P Y8AgWtX7mANzQ== Date: Wed, 11 Jun 2025 18:32:43 +0530 To: Amirreza Zarrabi Subject: Re: [PATCH v5 05/12] tee: increase TEE_MAX_ARG_SIZE to 4096 Message-ID: References: <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-0-024e3221b0b9@oss.qualcomm.com> <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-5-024e3221b0b9@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-5-024e3221b0b9@oss.qualcomm.com> X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.20 / 15.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[kernel.org:dkim]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:147.75.193.91]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; RCVD_IN_DNSWL_MED(-0.20)[147.75.193.91:from]; MIME_GOOD(-0.10)[text/plain]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[18]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:54825, ipnet:147.75.192.0/21, country:US]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Action: no action X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: CBE4B3F5BF Message-ID-Hash: S4X54JGUFCC25JMOIYQVS4JBSMS6PYRX X-Message-ID-Hash: S4X54JGUFCC25JMOIYQVS4JBSMS6PYRX X-MailFrom: sumit.garg@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Bjorn Andersson , Konrad Dybcio , Bartosz Golaszewski , Apurupa Pattapu , Kees Cook , "Gustavo A. R. Silva" , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Harshal Dev , linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Sumit Garg via OP-TEE Reply-To: Sumit Garg On Mon, May 26, 2025 at 11:56:50PM -0700, Amirreza Zarrabi wrote: > Increase TEE_MAX_ARG_SIZE to accommodate worst-case scenarios where > additional buffer space is required to pass all arguments to TEE. > This change is necessary for upcoming support for Qualcomm TEE, which > requires a larger buffer for argument marshaling. > > Signed-off-by: Amirreza Zarrabi > --- > include/uapi/linux/tee.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h > index 441d97add53f..71a365afb89b 100644 > --- a/include/uapi/linux/tee.h > +++ b/include/uapi/linux/tee.h > @@ -42,7 +42,7 @@ > #define TEE_IOC_MAGIC 0xa4 > #define TEE_IOC_BASE 0 > > -#define TEE_MAX_ARG_SIZE 1024 > +#define TEE_MAX_ARG_SIZE 4096 > > #define TEE_GEN_CAP_GP (1 << 0)/* GlobalPlatform compliant TEE */ > #define TEE_GEN_CAP_PRIVILEGED (1 << 1)/* Privileged device (for supplicant) */ > > -- > 2.34.1 > >