All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Levon <john.levon@nutanix.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>
Cc: qemu-devel@nongnu.org, chao.p.peng@intel.com,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE
Date: Wed, 11 Jun 2025 03:28:47 -0700	[thread overview]
Message-ID: <aElaX2XZr7wUVfng@lent> (raw)
In-Reply-To: <20250611024228.423666-1-zhenzhong.duan@intel.com>

On Wed, Jun 11, 2025 at 10:42:28AM +0800, Zhenzhong Duan wrote:

> Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice).
> It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same structure as
> base class VFIO_PCI_BASE, so no need to set its instance_size explicitly.
> 
> This isn't catastrophic only because VFIO_PCI_BASE is an abstract class.
> 
> Fixes: d4e392d0a99b ("vfio: add vfio-pci-base class")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>

Thanks! I had a similar patch after IRC discussion.

Reviewed-by: John Levon <john.levon@nutanix.com>

regards
john


      parent reply	other threads:[~2025-06-11 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  2:42 [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE Zhenzhong Duan
2025-06-11  6:43 ` Yi Liu
2025-06-11  7:19 ` Cédric Le Goater
2025-06-11  8:38   ` Duan, Zhenzhong
2025-06-11 10:28 ` John Levon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aElaX2XZr7wUVfng@lent \
    --to=john.levon@nutanix.com \
    --cc=alex.williamson@redhat.com \
    --cc=chao.p.peng@intel.com \
    --cc=clg@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.