Hi, On Tue, Jun 10, 2025 at 12:40:38PM -0700, Nathan Chancellor wrote: > This driver requires of_get_display_timing() from > CONFIG_VIDEOMODE_HELPERS but does not select it. If no other driver > selects it, there will be a failure from the linker if the driver is > built in or modpost if it is a module. > > ERROR: modpost: "of_get_display_timing" [drivers/gpu/drm/sitronix/st7571-i2c.ko] undefined! > > Select CONFIG_VIDEOMODE_HELPERS to resolve the build failure. > > Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller") > Signed-off-by: Nathan Chancellor > --- > drivers/gpu/drm/sitronix/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sitronix/Kconfig b/drivers/gpu/drm/sitronix/Kconfig > index c069d0d41775..741d1bb4b83f 100644 > --- a/drivers/gpu/drm/sitronix/Kconfig > +++ b/drivers/gpu/drm/sitronix/Kconfig > @@ -5,6 +5,7 @@ config DRM_ST7571_I2C > select DRM_GEM_SHMEM_HELPER > select DRM_KMS_HELPER > select REGMAP_I2C > + select VIDEOMODE_HELPERS > help > DRM driver for Sitronix ST7571 panels controlled over I2C. Good catch, it looks like this driver is missing the dependency. Reviewed-by: Marcus Folkesson