From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC09F29B79A for ; Thu, 12 Jun 2025 17:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749750584; cv=none; b=ITSsWtGr22DKQtcuFD2LgumOfnpYvFx0KD4XomzDLcQ6Pa9LR3nKzGrzu2GJYsiGniLvM7axBodjUe6Gnr9ZdkzGkFizeojzJ9icFZWatxP9W0jVjyDrHlCXhW+QNMj+4qhpgmRXLu2ziCBwAwPj5IEh+VQ3+EOUWXRiC9GqPc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749750584; c=relaxed/simple; bh=bdOP/dpPl/UU10GsQOaLEBHx9DtJHd4giISmHR0qzJg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aT7qN3TRf4BuUniV88tzmCMTdtuXaLCN7V4Z/SzxNmKnXmZizLJh9BeUFVos+s9vftYHxbbYOj/ro/h0EMDiSMGZDrQwnooCJ4gCwtiikLYNxxUXNNMthLdcH3aWXUx2iyH53boBRS4DiPJo5F1MkchOqUgJEQ247rp9WzEzg3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=1w6eSTYw; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="1w6eSTYw" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-73972a54919so1243981b3a.3 for ; Thu, 12 Jun 2025 10:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1749750581; x=1750355381; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kKudhM6GP7ucCr8LJ/xGTzdQhmTfuZa6CNBowxM0Kt8=; b=1w6eSTYwQvXrJY/0WPcquBS4DdRzRTQpxxUCCO+W4G1dFRCmLqRj/Er48RRbHWKqtP 8Ax2OzIAjbH0qcmENWxE4eqg9b1/MzZmDMU8ahfxIFXBb0RDtVMuD5d6UXwzueoMWb1n qqd3xoau/DNHSYV+7JEfbPPfoW2/hWGEiZaP97GSJNGmpZJp0x0v2ZJCHpqmQF/GYMxn 6Sn5b1a7DxDKAzMX8ckrIKTeIAmAgK8LrLsVNdFgu3tUAgplHMJG3cvTOKG4soriqlVu w9iUeXl4FlGW8obhTJzteIfyWO/Py78ULzaNmGT9aZhMa6HzxEKCpR//fzz5xGjlyry6 S1jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749750581; x=1750355381; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kKudhM6GP7ucCr8LJ/xGTzdQhmTfuZa6CNBowxM0Kt8=; b=HR6vfV34b3lmHToSAmYFX9rB5zQA+Q7sxJwYgcT8yew7N86Md9htprJqBiapOvu2Go RfZK79SQgcTXIx5Qyiw4FhA567SSzWbYye59fr2X3N2qnX1uZNxOjqY+TfWY6WZxtFP3 Uk22aos3p5v9uhp24aVNdgivVG+9/VkhyCz+dKcJ7P+Dod7NZJUHBUR/iciIOdpajtYe F26QdB9RvwADFEbUuWcKBlq4gDUGs8uOTymMsAh+evUbBhvBHN+jyfS4NYTzocBnd45L gPGXfAfCWBGP3t8xNM3ErAeQoBVKPNCoMXuN19u0WUgNffdx5dDHil4zW2ZcqdDc5JFG c51w== X-Forwarded-Encrypted: i=1; AJvYcCVKOLxyxTl5sJdAMXmYIkw8UiowtZseVpIY/qcicheqjvQHJBuyt2Yj4ZVdk8LUy3lzQ5QbElwYuQg=@vger.kernel.org X-Gm-Message-State: AOJu0YyJoUTkCvakLkulU6X3tZZmsyJaA1XUbOPyL+YDQ27Yjb6aSa69 W/ODMRHd9C5Z08vEr8WSZ+C1caXVrZ8wTf6y8XK/oyX6WNhcgX6NyXWo5277X7r0/as= X-Gm-Gg: ASbGnctUTMxNEQyUffFSKR858RuU9vDm7JFgRUAHkdTyTV5hxJlEFT7eH5EwrV1ROX6 qhyyuz3ZCK9jw5JjEUGpk1wAuqLOBXH01KxAKu6P9rb4ZpafU/q8s9bVGIb18b0y0ZH3CYYhpGa 1PD2j31CIWr6DctBwxqwVCfbM20ot7BoY7RZYo/kOOWgF3rwTSiO/zIPdRU3rOcLF2TrAytnm0b Hu1gfQHxxHOn/DgB3EWIj1DoULdbxd0R1OFza04kvS1nRci2rkLUTVa3D0Amd1UhWjlQOrxhOgf Q4BPRc7UmsdM57Bd7L5Tumgs7Yes8YkOAyyCRZ2k84AYTr8Zp4rNw9sQ3/K9c3vNDAg1iHqkmg= = X-Google-Smtp-Source: AGHT+IHLquFrw79+co4boFO8pJOfM9btk60nayGRQuNX/0ZumrQqIBCAkSYORT1Ip62N3F8udvKXLg== X-Received: by 2002:a05:6a00:984:b0:739:50c0:b3fe with SMTP id d2e1a72fcca58-7488f6cb9b2mr295006b3a.8.1749750581050; Thu, 12 Jun 2025 10:49:41 -0700 (PDT) Received: from x1 (97-120-245-201.ptld.qwest.net. [97.120.245.201]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748809eb146sm1837808b3a.109.2025.06.12.10.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 10:49:40 -0700 (PDT) Date: Thu, 12 Jun 2025 10:49:38 -0700 From: Drew Fustini To: Michal Wilczynski Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Benno Lossin , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Message-ID: References: <20250610-rust-next-pwm-working-fan-for-sending-v2-0-753e2955f110@samsung.com> <6ca6016e-3b17-48a0-ad8d-bb05317aa100@samsung.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jun 12, 2025 at 03:27:09PM +0200, Michal Wilczynski wrote: > > > On 6/12/25 07:01, Uwe Kleine-König wrote: > > Hello Drew, > > > > On Wed, Jun 11, 2025 at 04:52:22PM -0700, Drew Fustini wrote: > >> I also enabled the pwm fan driver. However, there is a probe failure: > >> > >> [ 1.250921] pwm-fan pwm-fan: Failed to configure PWM: -524 > >> [ 1.256546] pwm-fan pwm-fan: probe with driver pwm-fan failed with error -524 > > > > 524 = ENOTSUPP, so it seems the request had duty_offset > 0. Does your > > fan use PWM_POLARITY_INVERTED? If so, try without that flag. If your fan > > really needs an inverted PWM this of course makes fan control buggy. > > With the next revision it should work fine (as a duty_offset > 0 should > > get rounded down to 0). > > Since we're running the same DT, the polarity shouldn't be inverted. I > see you have CONFIG_PWM_DEBUG=y enabled, which is most likely the reason > the probe fails. Thanks, I've disabled that options and the probe completes okay. The fan is now spinning :) Drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 732EEC7114A for ; Thu, 12 Jun 2025 19:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vgyNV+iENkH8XlgyI4dTSoDSBtridog9las6YINvT0s=; b=4ILjOyF3zGOvzq FH3hTmoq8QXqGmPAfadXj7BI5fOMgaTdZ2+O9vXNENruD3xv6giT7PlrJ2m48WlkvlHiM5jUwy0cl tqlyBIK+HhVqNW0SAapWsHYqqeV+OPnBK1PRkWTRoznAo1sUVFLseAn0ZqP931seO4Tsi/6ncXUcn 3Jt+GAVnwIR/vIxBdy+6l1A5rCJoVEaUiFAF3RUxukcSFv1IMbQ/zD7ebJeqd84NhnFvslMHlpPMb QAHhxILeoBOpEnArRfZhW1FvtvD82Wf7yMyBQpDJguCC1ouDjDOWCHXg0frS/ebFHqYv293XnBW6K SjWjodFwLdKLr5W/UVMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPntQ-0000000ENcW-1wvx; Thu, 12 Jun 2025 19:47:20 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPm3Z-0000000E4oY-3xgC for linux-riscv@lists.infradead.org; Thu, 12 Jun 2025 17:49:43 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-747fc7506d4so1294014b3a.0 for ; Thu, 12 Jun 2025 10:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1749750581; x=1750355381; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kKudhM6GP7ucCr8LJ/xGTzdQhmTfuZa6CNBowxM0Kt8=; b=KPuTZdmZTE6NXoN+5gltrhE7dVxUkEiUVKaSmbMEA9jKR84e/P8bKn0NJsj8Bj+DXC bQz2aalDagSmTjHmZI1LuMTOTHuc5X7N67k7MDZbvE48hGqKiENVH/p5rkcEyeh+nUZA jCCD87B6Qkxnkdct00LNlKmQerW95GAQvohtcmTSZ3w3H+bfwtH3hI2sWnfo67IO15wi 7HYKig7r7R6Bc2zlowlNC4VexrF7aL7eFim+nHII0MaQectDuSrgSx2Vg1c8HkZiSKP4 JnqQAsQm1ZumXXnSXEXmnRO6t3Lr3sheEhbYCwqq7Ugm3qNmuO7ha+e51EKj3dnuNJLH dqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749750581; x=1750355381; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kKudhM6GP7ucCr8LJ/xGTzdQhmTfuZa6CNBowxM0Kt8=; b=wEUtfFPfBiyGtNG5naw9dqKUMNF6a+hOv1XYV1bigLV1dgYEclISIu3mSfd/MQ/LNo gP4TqtO2tnfGNP/ldG+ka8pTwiYhI34dZZZ0jo846+O7TOlVrDgnJm43kV2C9dfqlw7l I6SCcT2R4PTgfqDKl+SXwedO3CH2DqtcGWVgpmQyuOTKLHtA2cFnhqGpPY3Lqn/0m+91 0mOptMDDNf+0AXJH4XcJEvOfyIl3BtQxql1Y3ccMzQQOJ4xuUEeCEhmNaK24Sg3K2VtE am0w9KcW/agBbIzXRn4wKzxGBvGlJVBYXl2Zmx5wBElgnwm3WKhlzJYhGU2lju2vSsAD BA2Q== X-Forwarded-Encrypted: i=1; AJvYcCUs4dPEraq78ZhpqK3nps8Ta7dvb+IgdoKhMh5aXgNd2wnctSfUZZBk0AK+eOoQLA2ZlZ0jSim07Eblpw==@lists.infradead.org X-Gm-Message-State: AOJu0Yx6rlHo787ecLerzLb9EtmHTMzgFNlvAPpu8UptXHjBeE8kCMZq /7UTVuXmCGBXZn427xcBk6tgAk/nNAXsx8NVEkvBZOFtKXrp+RZlWFXfUGF871uaNxc= X-Gm-Gg: ASbGncuko1geUh2osrsa2GQ3iomasoKJ1X1IXtPnBB+vC6HYC3odNqNUTWTzx/o865E 6JMWIMbD9NbIcMeTrrxJvwtBreD9riYf8yVTPD2uuJ/cfe1Re5MLGQhsdcPlSh10AwJ+dSuHBOn Tv78sPR8zdfF3Hjzs/vYLIdYzfhQrfke2uIdiQGyKfqsYSgftlHjK5+PKU6Pbp3mSngU1cvaQE3 zWZ0X66yKbzfnFgdldpUkVG5tzu1DEwOXhQ1mOEXbLbzF5i2qX5NUE21o530o6TvtIfZu/7NLNY LqZOelb+3P8fW1QnJfXaPcVC+USta6nJxfgG1TOWFrnv5vtslEaU+jeCLZoDPGpP2yeghjg7mA= = X-Google-Smtp-Source: AGHT+IHLquFrw79+co4boFO8pJOfM9btk60nayGRQuNX/0ZumrQqIBCAkSYORT1Ip62N3F8udvKXLg== X-Received: by 2002:a05:6a00:984:b0:739:50c0:b3fe with SMTP id d2e1a72fcca58-7488f6cb9b2mr295006b3a.8.1749750581050; Thu, 12 Jun 2025 10:49:41 -0700 (PDT) Received: from x1 (97-120-245-201.ptld.qwest.net. [97.120.245.201]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748809eb146sm1837808b3a.109.2025.06.12.10.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 10:49:40 -0700 (PDT) Date: Thu, 12 Jun 2025 10:49:38 -0700 From: Drew Fustini To: Michal Wilczynski Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Benno Lossin , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Message-ID: References: <20250610-rust-next-pwm-working-fan-for-sending-v2-0-753e2955f110@samsung.com> <6ca6016e-3b17-48a0-ad8d-bb05317aa100@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250612_104942_067414_052A4F9A X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 12, 2025 at 03:27:09PM +0200, Michal Wilczynski wrote: > = > = > On 6/12/25 07:01, Uwe Kleine-K=F6nig wrote: > > Hello Drew, > > = > > On Wed, Jun 11, 2025 at 04:52:22PM -0700, Drew Fustini wrote: > >> I also enabled the pwm fan driver. However, there is a probe failure: > >> > >> [ 1.250921] pwm-fan pwm-fan: Failed to configure PWM: -524 > >> [ 1.256546] pwm-fan pwm-fan: probe with driver pwm-fan failed with = error -524 > > = > > 524 =3D ENOTSUPP, so it seems the request had duty_offset > 0. Does your > > fan use PWM_POLARITY_INVERTED? If so, try without that flag. If your fan > > really needs an inverted PWM this of course makes fan control buggy. > > With the next revision it should work fine (as a duty_offset > 0 should > > get rounded down to 0). > = > Since we're running the same DT, the polarity shouldn't be inverted. I > see you have CONFIG_PWM_DEBUG=3Dy enabled, which is most likely the reason > the probe fails. Thanks, I've disabled that options and the probe completes okay. The fan is now spinning :) Drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv