From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: tzimmermann@suse.de, simona.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/prime: remove drm_prime_lookup_buf_by_handle
Date: Fri, 13 Jun 2025 17:07:47 +0300 [thread overview]
Message-ID: <aEwws4nPXHNnK2Fa@intel.com> (raw)
In-Reply-To: <aEwrIrczo1rSx2rr@intel.com>
On Fri, Jun 13, 2025 at 05:04:31PM +0300, Ville Syrjälä wrote:
> On Wed, Jun 04, 2025 at 01:32:34PM +0200, Christian König wrote:
> > This was added by Sima +10 years ago as a solution to avoid exporting
> > multiple dma-bufs for the same GEM object. I tried to remove it before,
> > but wasn't 100% sure about all the side effects.
> >
> > Now Thomas recent modified drm_gem_prime_handle_to_dmabuf() which makes
> > it obvious that this is a superflous step. We try to look up the DMA-buf
> > by handle handle and if that fails for some reason (must likely because
> > the handle is a duplicate) the code just use the DMA-buf from the GEM
> > object.
> >
> > Just using the DMA-buf from the GEM object in the first place has the
> > same effect as far as I can see.
>
> This screwed up i915/xe:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16692/bat-twl-1/igt@prime_self_import@basic-with_one_bo.html
Never mind. Already being discussed.
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2025-06-13 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 11:32 [PATCH] drm/prime: remove drm_prime_lookup_buf_by_handle Christian König
2025-06-04 15:36 ` Simona Vetter
2025-06-04 16:21 ` Simona Vetter
2025-06-13 10:09 ` Jani Nikula
2025-06-13 10:18 ` Tvrtko Ursulin
2025-06-13 11:01 ` Jani Nikula
2025-06-13 12:11 ` Saarinen, Jani
2025-06-13 12:15 ` Christian König
2025-06-13 12:24 ` Christian König
2025-06-13 13:20 ` Simona Vetter
2025-06-13 13:58 ` Christian König
2025-06-13 13:16 ` Simona Vetter
2025-06-13 14:04 ` Ville Syrjälä
2025-06-13 14:07 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEwws4nPXHNnK2Fa@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=simona.vetter@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.