From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70720C71148 for ; Fri, 13 Jun 2025 18:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SGhLWOxHdV6sOh+CP4q4BVhRcqejcc7YZHRrvZqSn2A=; b=fUsWfYmRl1HtKczR13/Ca7tZLF khcywKBy0o3hUBQvZ7li9SebBsqpArE6EmS8MK0x9J5bP2zRtbcWIpuxRtpel4ij6+i/md2Wd0Sff gr0lIUnno6QkUv3Yma47/+dTX44v25NsIBUZ/wgudG2p1YI9GyeBSdPfY9TAkYMxLWobTVWnrDPNa BD/LoxETUwuAznb/CpKjvReAdulTxSbrMGvlN+Po5WFf5KY2kzwn9tRemCnIOBxnusqB2DiK90Zkz xVdBG/AUq52wqLeRAvxRo0A297O8OvmRv50TaIPGFjp6DcBavjNcICDw6lI/DIVi6ofEi3amDhV7r VmMxcn+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ8yM-0000000HHT5-0NON; Fri, 13 Jun 2025 18:17:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ79X-0000000H2ch-0fjH for kexec@lists.infradead.org; Fri, 13 Jun 2025 16:21:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD91E5C58EE; Fri, 13 Jun 2025 16:18:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04966C4CEE3; Fri, 13 Jun 2025 16:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749831674; bh=uZe79v3PpuM209FTqzpTU2PdWlQToBmu2a+dDo0xnGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTZR9j5vUqxTX+FdLcZFAkTMOQfxstLgp22Cxmz9jWmrsYp/Q2QVv0q0NTu/1cVox upey4uHrvINKd8Fmd8BBQu5Rw6uDMc+wlBYYCI0G1Hqc13TFps7Sd3r0kG3x4nhG94 2vVSIH+6au2xFh9ZvPO3SlSEop0sRdZRyCqvSls/p0j4Uf4ssbIKr54+NvCeRePjVo Xyv7dnFhwAsDU54g7BoA7zB7YhhG+eqnw2knkrnjxNw+aWLqp5DlS1l8WAhAKDynSU oOG7JYhu6L82a+15Z/0v3xrKBGf0KdailLX2QNtpL7tYe8OvxZTAeudamFhjpbFT5v s1HITNvZrCOpg== Date: Fri, 13 Jun 2025 19:21:07 +0300 From: Mike Rapoport To: Pratyush Yadav Cc: Pasha Tatashin , Alexander Graf , Changyuan Lyu , Andrew Morton , Baoquan He , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Clapinski Subject: Re: [PATCH] kho: initialize tail pages for higher order folios properly Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250613_092115_294039_1D7AA678 X-CRM114-Status: GOOD ( 50.30 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On Fri, Jun 13, 2025 at 04:22:32PM +0200, Pratyush Yadav wrote: > On Wed, Jun 11 2025, Mike Rapoport wrote: > > > On Wed, Jun 11, 2025 at 04:01:52PM +0200, Pratyush Yadav wrote: > >> On Wed, Jun 11 2025, Mike Rapoport wrote: > >> > >> > On Wed, Jun 11, 2025 at 09:14:55AM -0400, Pasha Tatashin wrote: > >> >> On Wed, Jun 11, 2025 at 9:06 AM Pratyush Yadav wrote: > >> >> > > >> >> > On Tue, Jun 10 2025, Pasha Tatashin wrote: > >> >> > > >> >> > >> > > I think it should be the other way around, KHO should depend on > >> >> > >> > > !DEFERRED_STRUCT_PAGE_INIT. > >> >> > >> > > >> >> > >> > Agreed, and this is what I first tried, but that does not work, there > >> >> > >> > is some circular dependency breaking the build. If you feel > >> >> > >> > adventurous you can try that :-) > >> >> > >> > >> >> > >> Hmm, weird, worked for me :/ > >> >> > > >> >> > Worked for me as well. > >> >> > > >> >> > > > >> >> > > I am super confused, it did not work for me over weekend, and now it > >> >> > > is working. Even `make menuconfig` would not work. Anyways, I will put > >> >> > > it in the appropriate place. > >> >> > > > >> >> > >> > >> >> > >> > > > We will need to teah KHO to work with deferred struct page init. I > >> >> > >> > > > suspect, we could init preserved struct pages and then skip over them > >> >> > >> > > > during deferred init. > >> >> > >> > > > >> >> > >> > > We could, but with that would mean we'll run this before SMP and it's not > >> >> > >> > > desirable. Also, init_deferred_page() for a random page requires > >> >> > >> > > >> >> > >> > We already run KHO init before smp_init: > >> >> > >> > start_kernel() -> mm_core_init() -> kho_memory_init() -> > >> >> > >> > kho_restore_folio() -> struct pages must be already initialized here! > >> >> > >> > > >> >> > >> > While deferred struct pages are initialized: > >> >> > >> > start_kernel() -> rest_init() -> kernel_init() -> > >> >> > >> > kernel_init_freeable() -> page_alloc_init_late() -> > >> >> > >> > deferred_init_memmap() > >> >> > >> > > >> >> > >> > If the number of preserved pages that is needed during early boot is > >> >> > >> > relatively small, that it should not be an issue to pre-initialize > >> >> > >> > struct pages for them before deferred struct pages are initialized. We > >> >> > >> > already pre-initialize some "struct pages" that are needed during > >> >> > >> > early boot before the reset are initialized, see deferred_grow_zone() > >> >> > >> > >> >> > >> deferred_grow_zone() takes a chunk in the beginning of uninitialized range, > >> >> > >> with kho we are talking about some random pages. If we preinit them early, > >> >> > >> deferred_init_memmap() will overwrite them. > >> >> > > > >> >> > > Yes, this is why I am saying that we would need to skip the KHO > >> >> > > initialized "struct pages" somehow during deferred initialization. If > >> >> > > we create an ordered by PFN list of early-initialized KHO struct > >> >> > > pages, skipping during deferred initialization could be done > >> >> > > efficiently. > >> >> > > >> >> > Or keep things simple and don't use any KHO struct pages during early > >> >> > init. You can access the page itself, just don't use its struct page. > >> >> > > >> >> > Currently the only user of kho_restore_folio() during init is > >> >> > kho_memory_init(). The FDT is accessed by doing > >> >> > phys_to_virt(kho_in.fdt_phys) anyway, so there is really no need for > >> >> > restoring the folio so early. It can be done later, for example when LUO > >> >> > does the finish event, to clean up and free the folio. > >> >> > >> >> Good suggestion, however, KHO does not have any sophisticated users > >> >> that we are going to be adding as part of the live update work in the > >> >> future: IR, KVM, early VCPU threads, and so on. So, while today, this > >> >> might work, in the future, I am not sure if we should expect struct > >> >> pages are not accessed until after deferred initialization or simply > >> >> fix it once and for all. > >> > > >> > KHO already accesses stuct page early and uses page->private for order. > >> > Since preserved memory is reserved in memblock, deferred init of struct > >> > pages won't touch those pages, we just need to make sure they are properly > >> > >> Not strictly true. Some of them might have been initialized from > >> free_area_init() -> memmap_init() (the ones not eligible for deferred > >> init), which happens before KHO makes its memblock reservations. > >> > >> > initialized at some point. If we don't expect many kho_restore_folio() > >> > before page_alloc_init_late() we can use init_deferred_page() for early > >> > accesses. > >> > >> I tried doing this when looking into this initially, but it doesn't work > >> for some reason. > >> > >> static void kho_restore_page(struct page *page, unsigned int order) > >> { > >> unsigned int i, nr_pages = (1 << order); > >> > >> /* Head page gets refcount of 1. */ > >> init_deferred_page(page_to_pfn(page), NUMA_NO_NODE); > > > > > > This would do > > > > if (early_page_initialised(pfn, nid)) > > return; > > > > __init_page_from_nid(pfn, nid); > > > > and I'm really surprised it didn't crash in early_page_initialised() > > because of NUMA_NO_NODE :) > > Oh, right. Using the wrong node completely throws > early_page_initialised() off. > > > > > What might work here is > > > > pfn = page_to_pfn(page); > > __init_page_from_nid(pfn, early_pfn_to_nid(pfn)); > > Yep, that works. Although this would do early_pfn_to_nid() for each page > so it isn't very efficient. And we also need to make sure memblock does > not go away. Yeah, that's far from ideal. Let's just gate KHO on !CONFIG_DEFERRED_PAGE_STRUCT_INIT for now. > >> set_page_count(page, 1); > >> > >> /* For higher order folios, tail pages get a page count of zero. */ > >> for (i = 1; i < nr_pages; i++) { > >> init_deferred_page(page_to_pfn(page + i), NUMA_NO_NODE); > >> set_page_count(page + i, 0); > >> } > >> > >> [...] > >> > [...] > > -- > Regards, > Pratyush Yadav -- Sincerely yours, Mike.