Re: [PATCH v11 14/14] unwind_user/x86: Enable compat mode frame pointer unwinding on x86

[Ingo Molnar <mingo@kernel.org>]

* Steven Rostedt <rostedt@goodmis.org> wrote:

> diff --git a/arch/x86/include/asm/unwind_user_types.h b/arch/x86/include/asm/unwind_user_types.h
> new file mode 100644
> index 000000000000..d7074dc5f0ce
> --- /dev/null
> +++ b/arch/x86/include/asm/unwind_user_types.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _ASM_UNWIND_USER_TYPES_H
> +#define _ASM_UNWIND_USER_TYPES_H

This is not the standard x86 header guard pattern ...

> +
> +#ifdef CONFIG_IA32_EMULATION
> +
> +struct arch_unwind_user_state {
> +	unsigned long ss_base;
> +	unsigned long cs_base;
> +};
> +#define arch_unwind_user_state arch_unwind_user_state

Ran out of newlines? ;-)

> +/*
> + * If an architecture needs to initialize the state for a specific
> + * reason, for example, it may need to do something different
> + * in compat mode, it can define arch_unwind_user_init to a
> + * function that will perform this initialization.

Please use 'func()' when referring to functions in comments.

> +/*
> + * If an architecture requires some more updates to the state between
> + * stack frames, it can define arch_unwind_user_next to a function
> + * that will update the state between reading stack frames during
> + * the user space stack walk.

Ditto.

Thanks,

	Ingo