All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, hare@suse.de, hch@infradead.org,
	yukuai3@huawei.com, john.g.garry@oracle.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@redhat.com, calvin@wbinvd.org, david@fromorbit.com,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	johnny.chenyi@huawei.com
Subject: Re: [PATCH] block: fix false warning in bdev_count_inflight_rw()
Date: Thu, 26 Jun 2025 03:11:54 -0700	[thread overview]
Message-ID: <aF0c6nqRwpyCFuAq@infradead.org> (raw)
In-Reply-To: <20250626083927.576207-1-yukuai1@huaweicloud.com>

I think you want to make the inflight array a signed type instead,
so that if the earlier CPUs have negative counts due to migration
that gets even out later on.  Which should also make the
counter not trigger normally.


      parent reply	other threads:[~2025-06-26 10:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26  8:39 [PATCH] block: fix false warning in bdev_count_inflight_rw() Yu Kuai
2025-06-26  8:54 ` Damien Le Moal
2025-06-26 11:32   ` Yu Kuai
2025-06-26  9:34 ` John Garry
2025-06-26 11:37   ` Yu Kuai
2025-06-26 10:11 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aF0c6nqRwpyCFuAq@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=calvin@wbinvd.org \
    --cc=david@fromorbit.com \
    --cc=hare@suse.de \
    --cc=john.g.garry@oracle.com \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yi.zhang@redhat.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.