From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from fgw22-7.mail.saunalahti.fi (fgw22-7.mail.saunalahti.fi [62.142.5.83])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id A387B238141
	for <nvdimm@lists.linux.dev>; Thu, 26 Jun 2025 21:57:17 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.83
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1750975040; cv=none; b=ZpllUTXfP+GOVtZb+vuA6/7rDOtXwuzskYOc4Z8IGbmjVmmS4t5PGF1ArZiLeq2in68ryiI7D7KK5LpMarRXu4hyIvzLjfn5FBn7bJT0eyXGHM64xvTi8PyID/OZoyymZCHB/YTVU9AxmS0u79YU3xvW/jIEJ4MJNUwtC48syUI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1750975040; c=relaxed/simple;
	bh=Js1/egzHau8cSrZDfwFjSH4T2I0dLiLhlUWEZZFXbB8=;
	h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=c9be9SUKny+DSVD+DQrLfokPfP2Veq4i4N/xpRF1a4WzkWExR+4Z7iENnPTRCRpT7ZHcaq4lj5LjGcMvDmZAxAocbqVfcKFcYD9Zhetqbd70cj/yG/EVDkjdRd97Fxens9/snXNkY2n/ZuFwzQtyg/C+e27PGxN6PLAi2Z/ag38=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.83
Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com
Received: from localhost (88-113-26-232.elisa-laajakaista.fi [88.113.26.232])
	by fgw22.mail.saunalahti.fi (Halon) with ESMTP
	id 7adf1deb-52d8-11f0-a5c4-005056bdf889;
	Fri, 27 Jun 2025 00:56:58 +0300 (EEST)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 27 Jun 2025 00:56:57 +0300
To: Ira Weiny <ira.weiny@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v1 1/1] libnvdimm: Don't use "proxy" headers
Message-ID: <aF3CKcVoO4aebaaG@surfacebook.localdomain>
References: <20250626153523.323447-1-andriy.shevchenko@linux.intel.com>
 <685dbdfb80651_2ce8302947e@iweiny-mobl.notmuch>
Precedence: bulk
X-Mailing-List: nvdimm@lists.linux.dev
List-Id: <nvdimm.lists.linux.dev>
List-Subscribe: <mailto:nvdimm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:nvdimm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <685dbdfb80651_2ce8302947e@iweiny-mobl.notmuch>

Thu, Jun 26, 2025 at 04:39:07PM -0500, Ira Weiny kirjoitti:
> Andy Shevchenko wrote:

...


> > +#include <linux/ioport.h>
> 
> If we are going in this direction why include ioport vs forward declaring
> struct resource?


I don't know where I looked when added this. This should be io.h.
And yes, we need forward declarations for struct resource and struct kobject.

...


> > -#include <linux/spinlock.h>
> > -#include <linux/bio.h>
> 
> I'm leaning toward including bio, module, and sysfs rather than do the
> forward declarations.

Header already uses forward declarations.

> Are forward declarations preferred these days?

Always with the dependency hell we have. For example, if we go your way we
would need to include of.h which is yet another monsteur. I prefer to use
this patch as provided.


-- 
With Best Regards,
Andy Shevchenko