From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Jim Cromie <jim.cromie@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: scx200_acb: add depends on HAS_IOPORT
Date: Fri, 27 Jun 2025 12:18:33 +0200 [thread overview]
Message-ID: <aF5v-dEVBsQGnmit@shikoro> (raw)
In-Reply-To: <20250615183659.902110-1-rdunlap@infradead.org>
On Sun, Jun 15, 2025 at 11:36:58AM -0700, Randy Dunlap wrote:
> The scx200_acb driver uses inb()/outb() without depending on HAS_IOPORT,
> which leads to build errors since kernel v6.13-rc1:
> commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n")
>
> Add the HAS_IOPORT dependency to prevent the build errors.
>
> (Found in ARCH=um allmodconfig builds)
>
> drivers/i2c/busses/scx200_acb.c: In function ‘scx200_acb_reset’:
> include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
>
> drivers/i2c/busses/scx200_acb.c:224:26: note: in expansion of macro ‘inb’
> include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
> 224 | status = inb(ACBST);
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Arnd Bergmann <arnd@kernel.org>
> Cc: Niklas Schnelle <schnelle@linux.ibm.com>
> Cc: Jim Cromie <jim.cromie@gmail.com>
> Cc: Andi Shyti <andi.shyti@kernel.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-i2c@vger.kernel.org
Applied to for-current, thanks!
next prev parent reply other threads:[~2025-06-27 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 18:36 [PATCH] i2c: scx200_acb: add depends on HAS_IOPORT Randy Dunlap
2025-06-27 10:18 ` Wolfram Sang [this message]
2025-06-27 10:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF5v-dEVBsQGnmit@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=arnd@kernel.org \
--cc=jim.cromie@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.