All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yi Sun <yi.sun@intel.com>,
	gordon.jin@intel.com, yi.sun@linux.intel.com,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Fenghua Yu <fenghuay@nvidia.com>
Subject: Re: [PATCH v2] dmaengine: idxd: Remove __packed from structures
Date: Fri, 27 Jun 2025 10:55:24 -0700	[thread overview]
Message-ID: <aF7bDA-evv2IsMoi@vaman> (raw)
In-Reply-To: <aF4YdFZnAWcZlpbW@surfacebook.localdomain>

On 27-06-25, 07:05, Andy Shevchenko wrote:
> Thu, Jun 26, 2025 at 03:48:11PM -0700, Vinod Koul kirjoitti:
> > 
> > On Fri, 04 Apr 2025 13:36:14 +0800, Yi Sun wrote:
> > > The __packed attribute introduces potential unaligned memory accesses
> > > and endianness portability issues. Instead of relying on compiler-specific
> > > packing, it's much better to explicitly fill structure gaps using padding
> > > fields, ensuring natural alignment.
> > > 
> > > Since all previously __packed structures already enforce proper alignment
> > > through manual padding, the __packed qualifiers are unnecessary and can be
> > > safely removed.
> 
> [...]
> 
> > Applied, thanks!
> 
> Please, don't or fix it ASAP. This patch is broken in the formal things,
> i.e. changelog entry must not disrupt SoB chain. I'm not sure if Stephen's
> scripts will catch this up on Linux Next integration, though.

Thanks for letting me know. My script didnt catch it, will check why.
I have fixed it up now

-- 
~Vinod

      parent reply	other threads:[~2025-06-27 17:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  5:36 [PATCH v2] dmaengine: idxd: Remove __packed from structures Yi Sun
2025-05-15 13:45 ` Yi Sun
2025-06-26 22:48 ` Vinod Koul
2025-06-27  4:05   ` Andy Shevchenko
2025-06-27  6:30     ` Yi Sun
2025-06-27  6:57       ` Andy Shevchenko
2025-06-27  7:15         ` Yi Sun
2025-06-27 17:55     ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aF7bDA-evv2IsMoi@vaman \
    --to=vkoul@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghuay@nvidia.com \
    --cc=gordon.jin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.sun@intel.com \
    --cc=yi.sun@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.