From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD317C71136 for ; Mon, 16 Jun 2025 15:36:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7A7BC80CE4; Mon, 16 Jun 2025 15:36:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 98acZgdgcRr8; Mon, 16 Jun 2025 15:36:05 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org BBA7C80CE8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1750088165; bh=BRhhjNzBpPywHz29LvHHa//rV6tmBgWp6eivc4x4ByQ=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=flV6xQNQOeV4EG60cjsOr/5h6f2RfCWhOorpdWjlen5GEK1jakOCIEYvmscRZfCk2 1PqtWoztPiKszBUD+jezilIBxMjXLjMs5LiUJM5XUOQ8kvGaWGv88XGbzM9P1QtUXq 8YnCGYOc+H4I8jTHzR2xKrZ81dI5G1I6s2tCgnE/+sgffUSINsJDq5SMgAa7ewZNn0 W+hw1yjMG2GfshPO8phLS096oBn7ov0WVXxhP7uui74yN08+Tz5ohIhLQJiDXTe6V/ I4y8Di3/Z2zLZ6UNh0HBsZxZw8EBFyTK46HkwqSG29b4AiMVWPSjsfpsl8iaR3SPfM qO8S+IEd7SOsg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id BBA7C80CE8; Mon, 16 Jun 2025 15:36:05 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id A47A9151 for ; Mon, 16 Jun 2025 15:36:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8ACA5408DF for ; Mon, 16 Jun 2025 15:36:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id N4YXIWvHenaH for ; Mon, 16 Jun 2025 15:36:04 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::32e; helo=mail-wm1-x32e.google.com; envelope-from=joe@dama.to; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org B970940899 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B970940899 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by smtp4.osuosl.org (Postfix) with ESMTPS id B970940899 for ; Mon, 16 Jun 2025 15:36:03 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-453398e90e9so24115705e9.1 for ; Mon, 16 Jun 2025 08:36:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750088162; x=1750692962; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRhhjNzBpPywHz29LvHHa//rV6tmBgWp6eivc4x4ByQ=; b=PmkjAOF7/+kMBiIipDfx0jr7X6tSWqh2v3Hd62J54bLvFVruqQ7OmDdj3E0F5YM4z5 VHkUSSg0QOI952TQ+3hkoCztRC4tGUsnsF9G0mpEWSVPSM/6MXikW04bUUvyF2y/7j+3 qqmYM7yvc+zcgIjaLg9m+3/3i0uqKN/mLLL9CIXoKGFOiDKd32W0fC9b9S+ox0sNWoPN AfQlvE6kzfRzahapvYVoQZocjAI3b3xEd8zHqjDYXlpI5ac1PW/8VLO6oBy5VOkxl2Um jgLVhArXK7+KwMSWVx+I+bbpG4wkiq+l5bWw9tqmp2nWEbfOlb4eVPNYUeF+uHj332cJ eFZw== X-Forwarded-Encrypted: i=1; AJvYcCUck//ckaK4gXOTh9rzYRZwQBbK1jKk9uLJVMMY0lyFlndg9zRBvWdA7xcA8lNidmeVqc9TUb6gleRDO4MWMcA=@lists.osuosl.org X-Gm-Message-State: AOJu0Yz55FxQrddFFQlr7IKyVAgUL3QHRz3ttJ8UiYLJddyD4tvO0v1R GyQzHMlG2ReUQYDWtgr3n4JxjM3XF6zZp4QD9m7kQiwNXOBSpOLBv6uhCjDK9rlM2KI= X-Gm-Gg: ASbGncu0CEVw0wAVtYpZNwl8QqC9rjW5CWm4DdlPx4KjEL3osZGI5cbP1oKZAa+tFG5 MhZGyvz7U/MDlinsRNZXABaYjseW+phtP8KCHfRB+DiKnmOr2uuM9yqmLiNQNAGZ5k0j6VeHN1l q0vVurLzA4QMVSwTLF59e2uG6zQERR936drCtoYoTcvXLKllk66P4+SOxpqNPf6aMVv24p7Xbtk k2D54V3+CwsburTSW5Mvy5XVv1TAdQd/IQgK8Qr8R1tXYjcnvNMyeeCXYb5kNeiGJKej5+I3Cl4 uW+l3MSxWPW0lYzua02+LJes1Sx6H28eN4i2ZxX1wB7si2wI+pn4mCnL1D2MnpkdLnY= X-Google-Smtp-Source: AGHT+IF/AJ0JSg6FcfBnP2RA68y0+f7I5WJcx4QXm83I71RwvNucpNeyvaBiE1GS+rUfNOA8YZy82A== X-Received: by 2002:a05:600c:6388:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-4533d49b94amr93119405e9.14.1750088161814; Mon, 16 Jun 2025 08:36:01 -0700 (PDT) Received: from MacBook-Air.local ([5.100.243.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm146441245e9.10.2025.06.16.08.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 08:36:01 -0700 (PDT) Date: Mon, 16 Jun 2025 18:35:58 +0300 From: Joe Damato To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com, michal.swiatkowski@linux.intel.com, Aleksandr Loktionov Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com, michal.swiatkowski@linux.intel.com, Aleksandr Loktionov References: <20250614180907.4167714-1-kuba@kernel.org> <20250614180907.4167714-8-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250614180907.4167714-8-kuba@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1750088162; x=1750692962; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=BRhhjNzBpPywHz29LvHHa//rV6tmBgWp6eivc4x4ByQ=; b=wfvr3HRJGUxX/o5IAY642YYzULOx/tTzCU6OqVnPQXJcnYaAzTCUpOrRBoyu17cIaL RgKJIK5O/ofYB/ElqUt7rp5AI3DSatYCUwfis6sRLWyI0MsccNKV3MkRey9hbs8ck+0S Pzj7iym9D7wbpCPauiQeXVH41jnJoGyp93Lnn4fxgzs4Z/OUhkJL5vdJ/g8avpWh6R9L 83RUa82kASr3fpFirqgzMZk1O9CfxfCWj6+u+6+AJ3wVAVjNpsmkkLjJN7Z8liqAhbpZ 3Yiphioa89WGFXLM+F3HIJVo3xpIwnZW/CoTNjsw00snN6jYR7TInBSla4Rv73Qk85rh g4KA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=dama.to X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=wfvr3HRJ Subject: Re: [Intel-wired-lan] [PATCH net-next v2 7/7] eth: iavf: migrate to new RXFH callbacks X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Jun 14, 2025 at 11:09:07AM -0700, Jakub Kicinski wrote: > Migrate to new callbacks added by commit 9bb00786fc61 ("net: ethtool: > add dedicated callbacks for getting and setting rxfh fields"). > > I'm deleting all the boilerplate kdoc from the affected functions. > It is somewhere between pointless and incorrect, just a burden for > people refactoring the code. > > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Jakub Kicinski > --- > .../net/ethernet/intel/iavf/iavf_ethtool.c | 52 ++++--------------- > 1 file changed, 11 insertions(+), 41 deletions(-) > Reviewed-by: Joe Damato From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71C682206AF for ; Mon, 16 Jun 2025 15:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750088165; cv=none; b=RyLLCxNyFU6SZECQhjYMeOLeN9j6ONlzlXleGzcUzwuXPGvn4y8txxu3SMRaYRFJRKqgtYZfnME0og5u6Nc73xGpEujV4Gv4VuDrX6Ms2geFKmIA0EkhNp2lk47TYJM7e5Z1Yajo1CQ+1eTf2gS18FdcttLZLUp6pN6DNHT5nqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750088165; c=relaxed/simple; bh=JyeYpEgfXXJs9sXcrw/TrRcixYECA3zNxMk3cMt6iQ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RKYK5sDJO3/sRU7c/V+2hXfCC6DyF0blViE6rks3zIS0bdtE6sTTawzMEefKQPuTQIJIRJ+1f4qQpJF1FpYvyS/sPKjwt2qFf9SQpLnNUnZ4RNk+k7tTnVJAMxxjtujzfzATQVi/B+gIPoEB1Q4dKv+F+oSoxdX5U6jcMQcdIJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=EWlJMGfe; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="EWlJMGfe" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-453398e90e9so24115695e9.1 for ; Mon, 16 Jun 2025 08:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1750088162; x=1750692962; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=BRhhjNzBpPywHz29LvHHa//rV6tmBgWp6eivc4x4ByQ=; b=EWlJMGfe754RmYjk23jSzZoheMndZ8tcrnqwggpVymKZEVV48m1YiZHvEHKnvM2t+5 tH2S+SffdYjcbkovHe7glxo38R+JeV2Cv4k1RbTXbrQ7fzoE9lrlGzMf4BbdkKGMTB5O 9hTAqY+F/mOYJR5N8K8323VHuup+lbcWots+Ew+j7mQKMVEzeMEoVlncaK4FqynTLUZy aZgYVeqTK3g4aaqLyVx7J5YiZw8uqqSnzyoFhqFql5EUZhI38w2rxw4eUZt2YQ1YfA6/ 9caO5G8OlQCqMxHnoES6vt71nnhUqrypLRs2ypoTlQFGtezen3/0tzkBNVXZJ0U3jMn2 p4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750088162; x=1750692962; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRhhjNzBpPywHz29LvHHa//rV6tmBgWp6eivc4x4ByQ=; b=IkZysGJWrkxEUYkbK44rHVKqRXVRnR7+nN2T3krIeAcoVMDaPUYbmSriJyIMblyI5K LnLeaLMvLFBn5jCxw1i+XFgpUT67jau2GySKakiqMOdFowqmg8T2EHYHAVvBOs1R1z07 1Fs7PnSQ6hORD7lWiInrTQLkIehNzqwe2umLACOwgyV0JpVG5zWkNWFixsQ4dZ2BwuXH ceRu8REOULInWBXZFJpXfEmRk6szyW75FwVEGXgi/zhHRdZcG5a0O0axi7LXKR7ZXShB 1S7/vubgvV/59xq/wy4zs7p5+WiGWWWDzei86yJ6s0OjL+fJP/+YS3gdTc8FAzIuptq5 nuDw== X-Forwarded-Encrypted: i=1; AJvYcCWo1geZ8S2c38pdIFHynAXzuMMr4v8HLNiWVf5PzT1pKG7GaXcnUzc9q5Y7ZAHORdLWrGPY5tU=@vger.kernel.org X-Gm-Message-State: AOJu0YxuZTnQ6a050FQostueg0uMx8ySAFp0DVoKFhdvVzLUL18TPQw7 i2SEnhbepTzV8QnkG279chLKIm8bhWLHQ5Wj3yFyvnZyP9sqgZBDOXX/hO5+49HHP1/KTV1CWSE LrXlgO4M= X-Gm-Gg: ASbGnct/ETHKcevpOa41xqUmLYgajourTYXJlws5STTbbRUJpFeiK1o1Fz7b9PkX/m8 BJyQVDSrzU53Z+sWLSivT8A144wEKani+IavekXXU2Qx3yd5sOcdaNwILk6XCI53ffVNLsmUlWh hEDdRkIgzx0TMM20qeoSEAFBzNAhdgpyKUtkIXzcuyUCz4fJtJYdGokiVenV+ZPFgYGVel6Ookt x2pkHIMpmj6T5zhbqrkD5WUwmJm8EKUmXYzqIHBDzSc16GeX/4b4eziUmAcQmEMU988fS+RuWsB Ztvm4yZm0qW0bExAlQO+yGYFjufcd8/TTyNCNdR0eJmG3137c4t/bLCWBM0gZ+DFWkY= X-Google-Smtp-Source: AGHT+IF/AJ0JSg6FcfBnP2RA68y0+f7I5WJcx4QXm83I71RwvNucpNeyvaBiE1GS+rUfNOA8YZy82A== X-Received: by 2002:a05:600c:6388:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-4533d49b94amr93119405e9.14.1750088161814; Mon, 16 Jun 2025 08:36:01 -0700 (PDT) Received: from MacBook-Air.local ([5.100.243.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm146441245e9.10.2025.06.16.08.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 08:36:01 -0700 (PDT) Date: Mon, 16 Jun 2025 18:35:58 +0300 From: Joe Damato To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com, michal.swiatkowski@linux.intel.com, Aleksandr Loktionov Subject: Re: [PATCH net-next v2 7/7] eth: iavf: migrate to new RXFH callbacks Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com, michal.swiatkowski@linux.intel.com, Aleksandr Loktionov References: <20250614180907.4167714-1-kuba@kernel.org> <20250614180907.4167714-8-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250614180907.4167714-8-kuba@kernel.org> On Sat, Jun 14, 2025 at 11:09:07AM -0700, Jakub Kicinski wrote: > Migrate to new callbacks added by commit 9bb00786fc61 ("net: ethtool: > add dedicated callbacks for getting and setting rxfh fields"). > > I'm deleting all the boilerplate kdoc from the affected functions. > It is somewhere between pointless and incorrect, just a burden for > people refactoring the code. > > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Jakub Kicinski > --- > .../net/ethernet/intel/iavf/iavf_ethtool.c | 52 ++++--------------- > 1 file changed, 11 insertions(+), 41 deletions(-) > Reviewed-by: Joe Damato