From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BD723B635; Tue, 17 Jun 2025 05:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750136947; cv=none; b=TYUgL7rThnKmg+NK4J1vCXt3HJVykdoebWpiUpF1bSSNWbHhvItYL/qRDKOrkSDOd+/5hrzXL2x7CveGQba5fHIvLODBTblPVgciPZTAgLA6HTWi8II/+MsAsj0RSWMT7i2VJFp1rUcCTPsb2po7+tStOwSIFszmJA2cuzGbV0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750136947; c=relaxed/simple; bh=PhPQQLZ5N9oyTqOW+Q9Ax4Uij5LekGBciexu/J54MQg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnvTOj+BOmsj4w5p2MOW0Amw9TMygv8BUfEp9PeHvInRr02hTiuKFzqNdrPxJoc7DWvC87byVzeslofEx0R4WVhGnGUKZ8bd9aKFgJWcgfRCF7Kj1PI4Zj/NvRvDhT/TVPPFuFldUkhZbtSrgqBOd0nCD8P9w3MCkUh+qDgCKSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=QNDoywVG; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QNDoywVG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MnSFdd8xjqrBRMNrjDtPx5JnmQica7Kdjxsp8Q9K/Q4=; b=QNDoywVGRFryPFg2RDAGbDqnER kMwwVaNvmdaPWaUdYiw4uVs1cwpES6Y1BZK6zmz6epnmQf/31dqrJ33hky4AO7LYDYrEmHWzT5Bgg VyfgKX5JeKt2VwytR3aURQTHJg+QRiPTD7MQPSSkuL5gSVT+THSOdd4vmpMu97aV9REIFv8EPvGoL F3fP2a1meh2mhDu+1cb3aNJjUMgJcQcJkdsXsvzXczzr8NFZjGt/s0pWBSaW/4wNY4j8IybNcONJm YgcOcrsyjgwc13MQm/OFO8/8KkG1q6x4Z+oB+mDwuoX4JPhpMCDIGJM1OzS7S4z578+cbogTh+9t6 xs0eBXpg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uROYF-00000006DYq-2nid; Tue, 17 Jun 2025 05:08:03 +0000 Date: Mon, 16 Jun 2025 22:08:03 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare Message-ID: References: Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote: > STATIC int > -xfs_file_mmap( > - struct file *file, > - struct vm_area_struct *vma) > +xfs_file_mmap_prepare( > + struct vm_area_desc *desc) Please stick to the existing alignment for the declarations. Otherwise this looks good. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58192C71155 for ; Tue, 17 Jun 2025 05:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X6FUozj6PkaJf+hUp6TB338FSD4PksvJnMmIh2MkRr8=; b=WUepIX/l1i4KLFAb+rQeoPLs7P NZsmgGKGT0gbLDbTEG/BGRMPKAlDizhZ5YxMcfMRlzetNtcXCI9EgME2C13noFRUhqVisxZp/5Xki 7rJ47GqioxSxy9Hu5MqlKScA96sdre8vBXOu9GEoht6GZNuYqO5v3KkgrmiMhA5Ux3MI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uROZQ-0001hF-Sv; Tue, 17 Jun 2025 05:09:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uROZP-0001h1-Ee; Tue, 17 Jun 2025 05:09:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MnSFdd8xjqrBRMNrjDtPx5JnmQica7Kdjxsp8Q9K/Q4=; b=A0adSDPPHTj9Z+WM30aa7DuGOW CagBDhLmMAXTtZAvpwfZnKeqvYiipiyUfXYg9Vru+bpOvVoanBm90uBq8/iWW9t/HkKAYcM8oJPSs 70q48h7Iw3sQwBH1H0tf8jb/0eJ+DgbUPdITTIpEzOGc0Bp6p/AW9uLK81r+6i1bVN3E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MnSFdd8xjqrBRMNrjDtPx5JnmQica7Kdjxsp8Q9K/Q4=; b=h7mI4c1sK7wxq3dbitrJzXxeLX riBV0og6uC9ncnA2avkA3kuXCmUs2zHnhyjvPNxmC603uCX/F4iyPJ8DZz0zScx4SHFMRU1nsjTa6 2czGkMkIeu0VlXLdEUYLPdPDzKpfccovtiboHCBMhK9FzOd0aDvcUDJMINAOmg/fSYM4=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uROZN-0002cw-EY; Tue, 17 Jun 2025 05:09:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MnSFdd8xjqrBRMNrjDtPx5JnmQica7Kdjxsp8Q9K/Q4=; b=QNDoywVGRFryPFg2RDAGbDqnER kMwwVaNvmdaPWaUdYiw4uVs1cwpES6Y1BZK6zmz6epnmQf/31dqrJ33hky4AO7LYDYrEmHWzT5Bgg VyfgKX5JeKt2VwytR3aURQTHJg+QRiPTD7MQPSSkuL5gSVT+THSOdd4vmpMu97aV9REIFv8EPvGoL F3fP2a1meh2mhDu+1cb3aNJjUMgJcQcJkdsXsvzXczzr8NFZjGt/s0pWBSaW/4wNY4j8IybNcONJm YgcOcrsyjgwc13MQm/OFO8/8KkG1q6x4Z+oB+mDwuoX4JPhpMCDIGJM1OzS7S4z578+cbogTh+9t6 xs0eBXpg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uROYF-00000006DYq-2nid; Tue, 17 Jun 2025 05:08:03 +0000 Date: Mon, 16 Jun 2025 22:08:03 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1uROZN-0002cw-EY Subject: Re: [f2fs-dev] [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Paulo Alcantara , dri-devel@lists.freedesktop.org, ceph-devel@vger.kernel.org, Mike Marshall , linux-xfs@vger.kernel.org, Tyler Hicks , devel@lists.orangefs.org, Shyam Prasad N , Jan Harkes , linux-um@lists.infradead.org, Joel Becker , Ronnie Sahlberg , John Paul Adrian Glaubitz , Eric Van Hensbergen , Christian Brauner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Trond Myklebust , Dave Kleikamp , Sandeep Dhavale , Simona Vetter , linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, codalist@coda.cs.cmu.edu, Namjae Jeon , ecryptfs@vger.kernel.org, Yangtao Li , Jani Nikula , ocfs2-devel@lists.linux.dev, Pedro Falcato , OGAWA Hirofumi , linux-block@vger.kernel.org, Theodore Ts'o , linux-f2fs-devel@lists.sourceforge.net, Hongbo Li , Anna Schumaker , Martin Brandenburg , Kees Cook , Yuezhang Mo , Carlos Maiolino , Joonas Lahtinen , Chris Mason , linux-mtd@lists.infradead.org, Jaegeuk Kim , Marc Dionne , Tvrtko Ursulin , linux-afs@lists.infradead.org, Naohiro Aota , Miklos Szeredi , Matthew Wilcox , coda@cs.cmu.edu, Viacheslav Dubeyko , Ilya Dryomov , linux-ext4@vger.kernel.org, Amir Goldstein , intel-gfx@lists.freedesktop.org, Damien Le Moal , Rodrigo Vivi , Dan Williams , Gao Xiang , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, Steve French , ntfs3@lists.linux.dev, linux-erofs@lists.ozlabs.org, jfs-discussion@lists.sourceforge.net, Jan Kara , linux-aio@kvack.org, Dominique Martinet , Christian Schoenebeck , Bob Copeland , Konstantin Komarov , Joseph Qi , Andreas Dilger , Mikulas Patocka , David Airlie , Anton Ivanov , Yue Hu , Richard Weinberger , Mark Fasheh , linux-bcachefs@vger.kernel.org, Jann Horn , Josef Bacik , "Liam R . Howlett" , Tom Talpey , Hans de Goede , Bharath SM , "Tigran A . Aivazian" , David Sterba , Xiubo Li , Ryusuke Konishi , Vlastimil Babka , Jens Axboe , Sungjong Seo , v9fs@lists.linux.dev, Kent Overstreet , linux-unionfs@vger.kernel.org, Benjamin LaHaise , Jeffle Xu , Johannes Berg , Johannes Thumshirn , David Woodhouse , linux-karma-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, Alexander Viro Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote: > STATIC int > -xfs_file_mmap( > - struct file *file, > - struct vm_area_struct *vma) > +xfs_file_mmap_prepare( > + struct vm_area_desc *desc) Please stick to the existing alignment for the declarations. Otherwise this looks good. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C322AC7114A for ; Tue, 17 Jun 2025 05:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SXDMn4UvB0OwBK6I4C2skn/KX2qgtIfpoycP2FNA1dY=; b=iDcJ8u7rlqdxzY zEkkbCAiWDX6UKrACOyBnQNLu4x324j713WJ56bgomZAYChZwqeoy+1lu+e4sTOZQtDH1RmnKfJos x6Q3E/wgJ9yZ/bKtaSqvfzwwxqHeKj1afltkDhgYrkWiCsrRuhwzqyKoNWjIyeKawjqpAjSCZLqc+ eErkiiopJ2cfkkZKizryYLjWKQ0Eu+kFAiOhl06B9VVlHxqz5ArMmQ3r6CutUtxcsESRvP9TYxjES xo3K3NIqn4smWvjadX58RgjHmad9AOTRh0ADjA9ei/2WlybYbfk14JCWCdCJLjlHOgm9TGWtCCfsn 1F1W7cI2BlizIY5I3BsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uROYW-00000006DZm-10Lw; Tue, 17 Jun 2025 05:08:20 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uROYF-00000006DYq-2nid; Tue, 17 Jun 2025 05:08:03 +0000 Date: Mon, 16 Jun 2025 22:08:03 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote: > STATIC int > -xfs_file_mmap( > - struct file *file, > - struct vm_area_struct *vma) > +xfs_file_mmap_prepare( > + struct vm_area_desc *desc) Please stick to the existing alignment for the declarations. Otherwise this looks good. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/