From: Ido Schimmel <idosch@idosch.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net-next] ipv6: Simplify link-local address generation for IPv6 GRE.
Date: Tue, 17 Jun 2025 19:46:02 +0300 [thread overview]
Message-ID: <aFGbyuXocIo3ejFC@shredder> (raw)
In-Reply-To: <a9144be9c7ec3cf09f25becae5e8fdf141fde9f6.1750075076.git.gnault@redhat.com>
On Mon, Jun 16, 2025 at 01:58:29PM +0200, Guillaume Nault wrote:
> Since commit 3e6a0243ff00 ("gre: Fix again IPv6 link-local address
> generation."), addrconf_gre_config() has stopped handling IP6GRE
> devices specially and just calls the regular addrconf_addr_gen()
> function to create their link-local IPv6 addresses.
>
> We can thus avoid using addrconf_gre_config() for IP6GRE devices and
> use the normal IPv6 initialisation path instead (that is, jump directly
> to addrconf_dev_config() in addrconf_init_auto_addrs()).
>
> See commit 3e6a0243ff00 ("gre: Fix again IPv6 link-local address
> generation.") for a deeper explanation on how and why GRE devices
> started handling their IPv6 link-local address generation specially,
> why it was a problem, and why this is not even necessary in most cases
> (especially for GRE over IPv6).
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-06-17 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 11:58 [PATCH net-next] ipv6: Simplify link-local address generation for IPv6 GRE Guillaume Nault
2025-06-17 16:46 ` Ido Schimmel [this message]
2025-06-19 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFGbyuXocIo3ejFC@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.