All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Michael Wyraz <michael@wyraz.de>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] Add Marvell ML352 to drivers/usb/serial/option.c
Date: Wed, 18 Jun 2025 16:27:58 +0200	[thread overview]
Message-ID: <aFLM7jZBEk6a7W-k@hovoldconsulting.com> (raw)
In-Reply-To: <aFJzdxe_ykNw6cP_@homebase1>

On Wed, Jun 18, 2025 at 10:06:15AM +0200, Michael Wyraz wrote:
> Add the device id of the Marvell ML352 to option.c so that the
> device is recognized as usb-serial device.
> 
> Signed-off-by: Michael Wyraz <michael@wyraz.de>

Thanks for the patch. Looks good, but we may not want to bind to every
interface of the device.

Can you please post the output of 'usb-devices' for this device? I
assume it has more than one interface, do what each interface is used
for?

If you end up resending, please use the common prefix in Subject, for
example:

	USB: serial: option: add support for Marvell ML352 

(e.g. as can been seen by running 'git log --oneline' on the files
you're changing).

Johan

  reply	other threads:[~2025-06-18 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18  8:06 [PATCH] Add Marvell ML352 to drivers/usb/serial/option.c Michael Wyraz
2025-06-18 14:27 ` Johan Hovold [this message]
2025-09-12  6:54   ` Michael Wyraz
2025-09-18  9:57     ` Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2025-06-04  5:40 Michael Wyraz
2025-06-04  7:33 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFLM7jZBEk6a7W-k@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael@wyraz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.