From: Florian Westphal <fw@strlen.de>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack-tools v2 0/2] conntrack: introduce --labelmap option to specify connlabel.conf path
Date: Thu, 19 Jun 2025 00:16:35 +0200 [thread overview]
Message-ID: <aFM6w6-koGXYTuOp@strlen.de> (raw)
In-Reply-To: <20250617104837.939280-1-c.heiss@proxmox.com>
Christoph Heiss <c.heiss@proxmox.com> wrote:
> Enables specifying a path to a connlabel.conf to load instead of the
> default one at /etc/xtables/connlabel.conf.
>
> nfct_labelmap_new() already allows supplying a custom path to load
> labels from, so it just needs to be passed in there.
>
> First patch is preparatory only; to make --labelmap
> position-independent.
>
> v1: https://lore.kernel.org/netfilter-devel/20250613102742.409820-1-c.heiss@proxmox.com/
>
> Changes v1 -> v2:
> * introduced preparatory patch moving label merging after arg parsing
> * removed redundant `if` around free() call
> * abort if --labelmap is specified multiple times
Changes look good to me, thanks.
I intend to apply this series in the next few days unless someone else
beats me to it (or has change requess).
prev parent reply other threads:[~2025-06-18 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 10:48 [PATCH conntrack-tools v2 0/2] conntrack: introduce --labelmap option to specify connlabel.conf path Christoph Heiss
2025-06-17 10:48 ` [PATCH conntrack-tools v2 1/2] conntrack: move label parsing after argument parsing Christoph Heiss
2025-06-19 22:15 ` Pablo Neira Ayuso
2025-06-17 10:48 ` [PATCH conntrack-tools v2 2/2] conntrack: introduce --labelmap option to specify connlabel.conf path Christoph Heiss
2025-06-18 22:16 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFM6w6-koGXYTuOp@strlen.de \
--to=fw@strlen.de \
--cc=c.heiss@proxmox.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.