From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02517C71157 for ; Wed, 18 Jun 2025 20:14:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A8DC10E937; Wed, 18 Jun 2025 20:14:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="i8eTqS6W"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B17310E930; Wed, 18 Jun 2025 20:14:43 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 043F35C627C; Wed, 18 Jun 2025 20:12:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61985C4CEE7; Wed, 18 Jun 2025 20:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750277677; bh=sw9XPuoboz5Zyke7ap1VbtdqXBQ7MhGyKF3T4RxE9i8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i8eTqS6WvGvFBZrIQPLraPRlTbl0S0z0BTl8mIebLfLJ3O+wHSv8NCUXxLEHFxgik 6K1Wcto63lQ6YY1UAs6jphHEWg4f7ddLy1Mj86GI9kD26KJjL1Vo/vdXoyGJw6T6rm BNY8PN34EBJfqGsDjVmQ5qm4zWEeQlIEU21C0wlAIsluCpOMusX849rt8HIVsCbvDa U6Fd0u+8peyGlw6eZgJ3K7AhKX8HrnB9boAXpvPlIZC67NVDkwRlFogpaSh5CZI/Pl /TaooLWSainf8sDgGY3D4plh+nzj823JCKWeRM6FYMZXeOsDVHpsDIgF4ES9fxh6Vl 8x4/tjGvjPhAQ== Date: Wed, 18 Jun 2025 22:14:29 +0200 From: Danilo Krummrich To: Alexandre Courbot Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Benno Lossin , John Hubbard , Ben Skeggs , Joel Fernandes , Timur Tabi , Alistair Popple , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Lyude Paul , Shirish Baskaran Subject: Re: [PATCH v5 00/23] nova-core: run FWSEC-FRTS to perform first stage of GSP initialization Message-ID: References: <20250612-nova-frts-v5-0-14ba7eaf166b@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250612-nova-frts-v5-0-14ba7eaf166b@nvidia.com> X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Thu, Jun 12, 2025 at 11:01:28PM +0900, Alexandre Courbot wrote: > Hi everyone, > > The feedback on v4 has been (hopefully) addressed. I guess the main > remaining unknown is the direction of the `num` module ; for this > iteration, following the received feedback I have eschewed the extension > trait and implemented the alignment functions as methods of the new > `PowerOfTwo` type. This has the benefit of making it impossible to call > them with undesirable (i.e. non-power of two) values. The `fls` function > is now provided as a series of const functions for each supported type, > generated by a macro. > > It feels like the `num` module could be its own series though, so if > there is still discussion about it, I can also extract it and implement > the functionality we need in nova-core as local helper functions until > it gets merged at its own pace. > > As previously, this series only successfully probes Ampere GPUs, but > support for other generations is on the way. > > Upon successful probe, the driver will display the range of the WPR2 > region constructed by FWSEC-FRTS with debug priority: > > [ 95.436000] NovaCore 0000:01:00.0: WPR2: 0xffc00000-0xffce0000 > [ 95.436002] NovaCore 0000:01:00.0: GPU instance built > > This series is based on v6.16-rc1 with no other dependencies. If compiled with rustc 1.78 there are missing imports of size_of() and align_of() which break the build. There are also a few warnings still: warning: unreachable `pub` field --> drivers/gpu/nova-core/fb.rs:79:5 | 79 | pub fb: Range, | ---^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = note: requested on the command line with `-W unreachable-pub` warning: unreachable `pub` field --> drivers/gpu/nova-core/fb.rs:80:5 | 80 | pub vga_workspace: Range, | ---^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` warning: unreachable `pub` field --> drivers/gpu/nova-core/fb.rs:81:5 | 81 | pub frts: Range, | ---^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` warning: 3 warnings emitted