All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mario Limonciello <superm1@kernel.org>
Cc: mario.limonciello@amd.com, bhelgaas@google.com,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: Fix runtime PM usage count underflow
Date: Thu, 19 Jun 2025 08:09:15 +0200	[thread overview]
Message-ID: <aFOpi9YxuBRp2_zg@wunner.de> (raw)
In-Reply-To: <20250616192813.3829124-3-superm1@kernel.org>

On Mon, Jun 16, 2025 at 02:26:57PM -0500, Mario Limonciello wrote:
> When a USB4 dock is unplugged the PCIe bridge it's connected to will
> remove issue a "Link Down" and "Card not detected event". The PCI core
> will treat this as a surprise hotplug event and unconfigure all downstream
> devices.
> 
> When PCI core gets to the point that the device is removed using
> pci_device_remove() the runtime count has already been decremented and
> so calling pm_runtime_put_sync() will cause an underflow.

Unfortunately this v2 does not address the review comment I provided
earlier:

   "Where has it been decremented?  I think this needs to be identified
    and a Fixes tag added."

   https://lore.kernel.org/r/aEb60TkaaLZ3kKIT@wunner.de/

Thanks,

Lukas

      reply	other threads:[~2025-06-19  6:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 19:26 [PATCH v2 0/2] Don't make noise about disconnected USB4 devices Mario Limonciello
2025-06-16 19:26 ` [PATCH v2 1/2] PCI: Don't show errors on inaccessible PCI devices Mario Limonciello
2025-06-19  6:14   ` Lukas Wunner
2025-06-19 13:36     ` Mario Limonciello
2025-06-16 19:26 ` [PATCH v2 2/2] PCI: Fix runtime PM usage count underflow Mario Limonciello
2025-06-19  6:09   ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFOpi9YxuBRp2_zg@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.