From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Mark Einon" <mark.einon@gmail.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Iyappan Subramanian" <iyappan@os.amperecomputing.com>,
"Keyur Chudgar" <keyur@os.amperecomputing.com>,
"Quan Nguyen" <quan@os.amperecomputing.com>,
"Łukasz Stelmach" <l.stelmach@samsung.com>,
"Michael Chan" <michael.chan@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Doug Berger" <opendmb@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Pavan Chebbi" <pavan.chebbi@broadcom.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Jian Shen" <shenjian15@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Parthiban Veerasooran" <parthiban.veerasooran@microchip.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Jiawen Wu" <jiawenwu@trustnetic.com>,
"Mengyuan Lou" <mengyuanlou@net-swift.com>,
"Imre Kaloz" <kaloz@openwrt.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Steve Glendinning" <steve.glendinning@shawell.net>,
UNGLinuxDriver@microchip.com, "Simon Horman" <horms@kernel.org>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>
Subject: Re: [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy_detach
Date: Fri, 20 Jun 2025 15:56:07 +0100 [thread overview]
Message-ID: <aFV2h4w3MLtjyfPb@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250620143341.2158655-1-kory.maincent@bootlin.com>
On Fri, Jun 20, 2025 at 04:33:27PM +0200, Kory Maincent wrote:
> phy_detach needs the rtnl lock to be held. It should have been added before
> to avoid this massive change among lots of net drivers but there was no
> clear evidence of such needs at that time. This imply a lock change in
> this API. Add phy_detach_rtnl, phy_diconnect_rtnl, phylink_connect_phy_rtnl
> and phylink_fwnode_phy_connect_rtnl helpers to take the lock before calling
> their respective function.
Please don't increase the number of API functions for phylink for the
long term. I'd prefer all callers of the phylink phy_connect functions
be updated to hold the RTNL, just like phylink_disconnect() requires.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-06-20 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 14:33 [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy_detach Kory Maincent
2025-06-20 14:56 ` Russell King (Oracle) [this message]
2025-06-20 16:25 ` Florian Fainelli
2025-06-21 7:48 ` Andrew Lunn
2025-06-21 8:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFV2h4w3MLtjyfPb@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Shyam-sundar.S-k@amd.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=afaerber@suse.de \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=iyappan@os.amperecomputing.com \
--cc=jiawenwu@trustnetic.com \
--cc=kaloz@openwrt.org \
--cc=keyur@os.amperecomputing.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mark.einon@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mengyuanlou@net-swift.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=olteanv@gmail.com \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=pavan.chebbi@broadcom.com \
--cc=quan@os.amperecomputing.com \
--cc=rafal@milecki.pl \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sgoutham@marvell.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=steve.glendinning@shawell.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=ulli.kroll@googlemail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.